wxGUI Add web service layer: Fix dialog layout #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
requested changes
May 13, 2020
gui/wxpython/web_services/widgets.py
Outdated
| @@ -230,6 +230,12 @@ def _requestPage(self): | |||
|
|
|||
| self.req_page_panel.SetSizer(self.req_page_sizer) | |||
|
|
|||
| size = list(self.req_page_sizer.GetMinSize()) | |||
There was a problem hiding this comment.
This seems little weird, I would rather set the minimum height as fixed e.g.:
self.SetMinSize((-1, 300))
There was a problem hiding this comment.
I'm using Gentoo distro (4.0.7.post2 gtk3 (phoenix) wxWidgets 3.0.4) with dynamic window manager (main difference against Ubuntu distro) for X. It's work properly on Ubuntu 18.04 distro (dialog height expand to max desktop visible height). Alright, I updated it.
tmszi
force-pushed
the
fix_add_web_service_layer_dialog_layout
branch
from
d0b35c7
to
ec205e1
Compare
|
I have the same problem in fedora 31 (I get exactly the same that you show in the first screenshot) which makes it unusable because it is impossible to resize. |
|
Thanks! |
Yes! It works nicely now. Thanks for the fix :) |
petrasovaa
pushed a commit
that referenced
this pull request
May 13, 2020
* wxGUI AddWSDialog: set Advanced request settings page ScrolledPanel widget * wxGUI AddWSDialog: set WSPanel widget min size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Set Request page BoxSizer widget min size
To reproduce:
Default dialog (Request page) layout:
Expected dialog (Request page) layout:
2. Set Advanced request settings page ScrolledPanel widget
To reproduce:
http://gis.nature.cz/arcgis/services/Aplikace/Opendata/MapServer/WmsServerin the Server TextCtrl widgetDefault dialog (Advanced request settings page) layout:
Expected dialog (Advanced request settings page) layout: