Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: modernize app bundle info #941

Merged
merged 1 commit into from
Sep 21, 2020
Merged

macOS: modernize app bundle info #941

merged 1 commit into from
Sep 21, 2020

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Aug 27, 2020 •
edited
Loading

This updates mac app bundle info:

  • updated Info.plist
  • renamed app icon
  • added gxw document icon (and the svg file it was created from)

While not solves #457, this is a step towards it. For the time being, the new Info.plist may be used (patched) by packagers.

Screenshot of the gxw document icon:
Screenshot

@nilason nilason added this to the 7.8.4 milestone Aug 31, 2020
@nilason
macOS: modernize app bundle info
402dbc8 
- updated Info.plist
- renamed app icon
- added gxw document icon
@nilason
Copy link
Contributor Author

nilason commented Aug 31, 2020

@cmbarton While it is not really testable, as the --enable-macosx-app will not produce a usable app, I have made changes to the same effect to https://github.com/nilason/grass-conda.

@cmbarton
Copy link
Contributor

@cmbarton While it is not really testable, as the --enable-macosx-app will not produce a usable app, I have made changes to the same effect to https://github.com/nilason/grass-conda.

Indeed. These are really outstanding and will make it much easier for Mac users to compile on their own if they so choose.

@nilason
Copy link
Contributor Author

nilason commented Aug 31, 2020

I meant, I made a couple of hours ago some changes to grass-conda, that mirrors the changes of this PR. Please try it out. Specifically see if the gxw document icon is displayed.

@neteler
Copy link
Member

neteler commented Sep 21, 2020

Shall this still go into 7.8.4 which is overdue? I suggest to move the milestone otherwise.

@neteler neteler added the macOS macOS specific label Sep 21, 2020
@nilason
Copy link
Contributor Author

nilason commented Sep 21, 2020

This can safely go to 7.8.4. The files modified by this PR are nowadays not in use anywhere (except the app icon, which I only renamed). Therefore: not much to break! :)
On the other hand, the changes reflect what is in use already with Michael's binary.

@neteler
Copy link
Member

neteler commented Sep 21, 2020

Will you or shall I merge it and backport?

@nilason
Copy link
Contributor Author

nilason commented Sep 21, 2020

Will you or shall I merge it and backport?

I don't think I have the authority to do that, do I?
Anyway, please do merge and backport.

@neteler neteler merged commit fbf13c0 into OSGeo:master Sep 21, 2020
neteler pushed a commit that referenced this pull request Sep 21, 2020
@nilason @neteler
macOS: modernize app bundle info (#941)
d0c0a43 
- updated Info.plist
- renamed app icon
- added gxw document icon
@neteler
Copy link
Member

neteler commented Sep 21, 2020

Done and done!

@nilason
Copy link
Contributor Author

nilason commented Sep 21, 2020

Done and done!

Thank you!

@nilason nilason deleted the macos-modernize-Infoplist branch September 29, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
macOS macOS specific
Projects
None yet
Milestone
7.8.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nilason @cmbarton @neteler