Reflect grassdb changes in catalog #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
requested changes
Oct 29, 2020
There was a problem hiding this comment.
It works for me with and without watchdog.
When I switch to an empty mapset and create new maps, the node does not expand (although the content is updated).
In the review, I'm mainly asking for more documentation. Some motivation cane be also included in the commit message if needed.
wenzeslaus
reviewed
Oct 29, 2020
wenzeslaus
approved these changes
Nov 18, 2020
wenzeslaus
moved this from Waiting for review
to Done
in OSGeo Virtual Community Sprint 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new signal to update catalog tree when a change in grass database happened.
So far it covers cases when a new map is created through running a module (from command line or dialog), imports, mapcalc.
Also updates tree when new mapset/location is created from menu. Here it changes behavior, it doesn't automatically switch to the new mapset. Supersedes/incorporates #916.
Additionally it uses python watchdog library to observe current mapset to reflect changes from terminal or other sources not covered by mechanism above. Only current mapset is observed because there is a low default limit on how many files can be watched. Watchdog is not part of standard Python lib but can be installed through pip, the PR should work without it, missing changes done externally.
Fixes #885.