QGIS v3.2.0

[fjperini]

The formula works correctly for gis/homebrew-qgisdev. Was added brewsci/bio for fixmatplotlib. For more details, see this issue.

[nickrobison]

Thanks for this! A few comments on the formula.

Also, what are the new files introduced in the scripts directory for?

One point of discussion, qt-webkit is deprecated and no longer shipped with QT5. Unless there's a compelling reason to keep it, I would suggest disabling it in the build. Otherwise we'll probably end up having to support our own Q5 version. Which I'd like to avoid.

@3nids @luisspuerto and @kbevers might have some thoughts on whether or not we can remove webkit support.

[kbevers]

@3nids @luisspuerto and @kbevers might have some thoughts on whether or not we can remove webkit support.

I don't know anything about it. But if it is not a part of QT5 I think it should be removed. It's going to be a pain to maintain a separate qt formula!

[fjperini]

Great @nickrobison , I see that you're already in it. I wait for those changes to try again.

[nickrobison]

@fjperini We might want to hold off on making any changes until I can get #404 merged in, along with an update to pyqt5-webkit which is also causing issues.

Once that gets merged, I'll need you to rebase against master. I made some changes to the build process to handle installing webkit in the sandbox. Plus, we'll need to latest bottle, otherwise the Travis job will never complete.

[fjperini]

Sure, I understand. 👍

[nickrobison]

@fjperini qt5-webkit and pyqt5-webkit have been rebuilt and updated to the latest versions. Can you rebase against master and try your build again?

[fjperini]

Yes @nickrobison, I think we'll have to do a new pull to make it cleaner(if required). It seems to you to rename the formula to only qgis?

Let's try to see how it turns out.

[nickrobison]

Are you asking if I renamed the formula, or if we should rename to to simply, qgis?

I think we should keep the qgis3 name for now, because that's consistent with what we name things in this tap. I've been thinking about moving to the @3 suffix like they do in core, but we'll see.

I think a new PR is a great idea, I'm also about to push a commit that should remove the need to build with the --no-sandbox flag, so I'll let you know when that's ready.

[nickrobison]

Looks like we'll need to hold off until the bottle rebuild is done. Should only be a few more minutes, then I'll restart the build. I just pushed a bunch of updates to GDAL.

[fjperini]

Ok, I thought it was just a connection problem.

[fjperini]

Yes @nickrobison , we leave it like that. I await your news.

[fjperini]

@nickrobison For some reason I am having this error:

0.02s$ ./travis/install.sh
./travis/install.sh: line 22: syntax error near unexpected token `<<<'

It's a syntax problem, but I do not visualize it. You can see it?

[nickrobison]

With the commit history, it's really hard to see what's going on and where the various changes are coming from. Can you please squash down to a commit or two and rebase against master?

If you need to create a new PR to make it easier, that would work too. Thanks!

[fjperini]

Yes I agree! Better to open a new PR.