Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QGIS v3.2.1 #429

Merged
merged 7 commits into from
Aug 7, 2018
Merged

Add QGIS v3.2.1 #429

merged 7 commits into from
Aug 7, 2018

Conversation

fjperini
Copy link
Collaborator

@fjperini fjperini commented Aug 2, 2018

This new pull is for to have a version of #413 cleaned.

The new qgis3 is ready, manual intervention is no longer necessary 🎉

It just finished installing. Everything was installed correctly!

@nickrobison gdal2-python was built with python3.6, it is necessary to update the bottle to avoid problems with some modules.

Thank you very much to all! @nickrobison @luisspuerto

I hope you can install it without problems!

@3nids
Copy link
Collaborator

3nids commented Aug 2, 2018

awesome!!!! thanks a lot for all the efforts!

@luispuerto
Copy link
Collaborator

my build still fails and I don't know why...

something related to qt5.

https://gist.github.com/luisspuerto/48f7cd33396fb2e9c31a7e0217d3c94b

any idea is appreciated

@3nids
Copy link
Collaborator

3nids commented Aug 2, 2018

@luisspuerto apparently you miss Qt webkit.
Either install osgeo/osgeo4mac/qt5-webkit and osgeo/osgeo4mac/pyqt5-webkit or install QGIS with --without-qt5-webkit option.

@luispuerto
Copy link
Collaborator

@3nids thanks for the insight... but I have both of those installed, and I've installed both again, just in case. Do you know how I can make them "visible" to the install?

@luispuerto
Copy link
Collaborator

curious enough... after I reinstalled pyqt5-webkit I get a different error related with python.

==> cmake -G Ninja -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCMAKE_INSTALL_PREFIX=/usr/local
==> cmake --build . --target all -- -j 8
Last 15 lines from /Users/lpuerto/Library/Logs/Homebrew/qgis3/28.cmake:
FAILED: python/plugins/db_manager/resources_rc.py
cd /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/plugins/db_manager && /usr/local/bin/pyrcc5 -o /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/plugins/db_manager/resources_rc.py /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/python/plugins/db_manager/resources.qrc
/usr/local/bin/pyrcc5: line 2: exec: pythonw3: not found
[493/4816] /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++  -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_NO_CAST_TO_ASCII -DWITH_BINDINGS -DWITH_QTWEBKIT -Dqgis_native_EXPORTS -I. -I../src/native -Isrc/native -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include/darwin -isystem /usr/local/Cellar/grass7/7.4.1/grass-base/include -isystem /usr/local/opt/gettext/include -F/usr/local/opt/qt/lib -Wall -Wextra -Wno-long-long -Wformat-security -Wno-strict-aliasing -Wno-return-type-c-linkage -Wno-overloaded-virtual -Qunused-arguments -O2 -g -DNDEBUG -fPIC -fvisibility=hidden   -std=gnu++11 -x objective-c++ -MD -MT src/native/CMakeFiles/qgis_native.dir/mac/qgsmacnative.mm.o -MF src/native/CMakeFiles/qgis_native.dir/mac/qgsmacnative.mm.o.d -o src/native/CMakeFiles/qgis_native.dir/mac/qgsmacnative.mm.o -c ../src/native/mac/qgsmacnative.mm
[494/4816] /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++  -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_NO_CAST_TO_ASCII -DWITH_BINDINGS -DWITH_QTWEBKIT -Dqgis_native_EXPORTS -I. -I../src/native -Isrc/native -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include/darwin -isystem /usr/local/Cellar/grass7/7.4.1/grass-base/include -isystem /usr/local/opt/gettext/include -F/usr/local/opt/qt/lib -Wall -Wextra -Wno-long-long -Wformat-security -Wno-strict-aliasing -Wno-return-type-c-linkage -Wno-overloaded-virtual -Qunused-arguments -O2 -g -DNDEBUG -fPIC -fvisibility=hidden   -std=gnu++11 -x objective-c++ -MD -MT src/native/CMakeFiles/qgis_native.dir/mac/cocoainitializer.mm.o -MF src/native/CMakeFiles/qgis_native.dir/mac/cocoainitializer.mm.o.d -o src/native/CMakeFiles/qgis_native.dir/mac/cocoainitializer.mm.o -c ../src/native/mac/cocoainitializer.mm
[495/4816] cd /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/plugins/processing/algs/help && /usr/local/Cellar/cmake/3.12.0/bin/cmake -P /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/plugins/processing/stageinstall.cmake
[496/4816] cd /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E echo && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E touch /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/server/sip_serverpart0.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/server/sip_serverpart1.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/server/sip_serverpart2.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/server/sip_serverpart3.cpp && /usr/local/Cellar/sip/4.19.8_5/bin/sip -w -e -x TESTS -x ANDROID -x ARM -x MOBILITY_LOCATION -t WS_MACX -t Qt_5_11_1 -g -o -a /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/qgis.server.api -y /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/output/python/qgis/_server.pyi -j 4 -c /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/server -I /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/server -I /usr/local/share/sip/Qt5 -I /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/python /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/server/server.sip

[497/4816] cd /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E echo && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E touch /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/analysis/sip_analysispart0.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/analysis/sip_analysispart1.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/analysis/sip_analysispart2.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/analysis/sip_analysispart3.cpp && /usr/local/Cellar/sip/4.19.8_5/bin/sip -w -e -x TESTS -x ANDROID -x ARM -x MOBILITY_LOCATION -t WS_MACX -t Qt_5_11_1 -g -o -a /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/qgis.analysis.api -y /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/output/python/qgis/_analysis.pyi -j 4 -c /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/analysis -I /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/analysis -I /usr/local/share/sip/Qt5 -I /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/python /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/analysis/analysis.sip

[498/4816] cd /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E echo && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E touch /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/core/sip_corepart0.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/core/sip_corepart1.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/core/sip_corepart2.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/core/sip_corepart3.cpp && /usr/local/Cellar/sip/4.19.8_5/bin/sip -w -e -x TESTS -x ANDROID -x ARM -x MOBILITY_LOCATION -t WS_MACX -t Qt_5_11_1 -g -o -a /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/qgis.core.api -y /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/output/python/qgis/_core.pyi -j 4 -c /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/core -I /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/core -I /usr/local/share/sip/Qt5 -I /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/python /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/core/core.sip

[499/4816] cd /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E echo && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E touch /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/gui/sip_guipart0.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/gui/sip_guipart1.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/gui/sip_guipart2.cpp /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/gui/sip_guipart3.cpp && /usr/local/Cellar/sip/4.19.8_5/bin/sip -w -e -x TESTS -x ANDROID -x ARM -x MOBILITY_LOCATION -t WS_MACX -t Qt_5_11_1 -g -o -a /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/qgis.gui.api -y /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/output/python/qgis/_gui.pyi -I /usr/local/opt/qscintilla2/share/sip -j 4 -c /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/gui -I /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/gui -I /usr/local/share/sip/Qt5 -I /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/python /tmp/qgis3-20180802-91926-1enakpu/QGIS-final-3_2_1/build/python/gui/gui.sip

ninja: build stopped: subcommand failed.

If reporting this issue please do so to (not Homebrew/brew or Homebrew/core):
osgeo/osgeo4mac

@luispuerto
Copy link
Collaborator

luispuerto commented Aug 2, 2018

now, after I reinstalled python, it has returned to the original error: https://gist.github.com/luisspuerto/48f7cd33396fb2e9c31a7e0217d3c94b

😞

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 3, 2018

@luisspuerto If the problem you have is that you do not find qt5-webkit and pyqt5-webkit, it will be easy to fix it.

Checking, we can see that you are using qt5-webkit.

[914/4816] /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++  -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_POSITIONING_LIB -DQT_PRINTSUPPORT_LIB -DQT_SQL_LIB -DQT_SVG_LIB -DQT_WEBKITWIDGETS_LIB -DQT_WEBKIT_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -DTEST_DATA_DIR=\"/tmp/qgis3-20180802-76863-8dubd1/QGIS-final-3_2_1/tests/testdata\" -DWITH_BINDINGS -DWITH_QTWEBKIT -D_HAVE_PTHREAD_ -D_TTY_POSIX_ -Dqgis_core_EXPORTS -I. -I../src/core -Isrc/core -I../src/core/3d -I../src/core/annotations -I../src/core/auth -I../src/core/dxf -I../src/core/effects -I../src/core/expression -I../src/core/fieldformatter -I../src/core/geometry -I../src/core/geocms -I../src/core/geocms/geonode -I../src/core/layertree -I../src/core/layout -I../src/core/locator -I../src/core/metadata -I../src/core/pal -I../src/core/processing -I../src/core/processing/models -I../src/core/providers -I../src/core/providers/memory -I../src/core/raster -I../src/core/renderer -I../src/core/scalebar -I../src/core/symbology -I../src/core/mesh -I../external/nmea -I../external/qextserialport -isystem /usr/local/include -isystem /usr/local/include/spatialindex -isystem /usr/local/opt/gdal2/include -isystem /usr/local/opt/expat/include -isystem /usr/local/opt/sqlite/include -isystem /usr/local/lib/qca-qt5.framework/Headers -isystem /usr/local/include/qt5keychain -iframework /usr/local/opt/qt/lib -isystem /usr/local/opt/qt/lib/QtXml.framework/Headers -isystem /usr/local/opt/qt/lib/QtCore.framework/Headers -isystem /usr/local/opt/qt/./mkspecs/macx-clang -isystem /usr/local/opt/qt/lib/QtGui.framework/Headers -isystem /System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers -isystem /usr/local/opt/qt/lib/QtWidgets.framework/Headers -isystem /usr/local/opt/qt/lib/QtSvg.framework/Headers -isystem /usr/local/opt/qt/lib/QtPrintSupport.framework/Headers -isystem /usr/local/opt/qt/lib/QtNetwork.framework/Headers -isystem /usr/local/opt/qt5-webkit/include -isystem /usr/local/opt/qt5-webkit/include/QtWebKitWidgets -isystem /usr/local/opt/qt5-webkit/include/QtWebKit -isystem /usr/local/opt/qt/lib/QtSql.framework/Headers -isystem /usr/local/opt/qt/lib/QtConcurrent.framework/Headers -isystem /usr/local/opt/qt/lib/QtPositioning.framework/Headers -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include/darwin -isystem /usr/local/Cellar/grass7/7.4.1/grass-base/include -isystem /usr/local/opt/gettext/include -F/usr/local/opt/qt/lib -Wall -Wextra -Wno-long-long -Wformat-security -Wno-strict-aliasing -Wno-return-type-c-linkage -Wno-overloaded-virtual -Qunused-arguments -O2 -g -DNDEBUG -fPIC -fvisibility=hidden   -F/usr/local/lib  -fPIC -std=gnu++11 -MD -MT src/core/CMakeFiles/qgis_core.dir/annotations/qgshtmlannotation.cpp.o -MF src/core/CMakeFiles/qgis_core.dir/annotations/qgshtmlannotation.cpp.o.d -o src/core/CMakeFiles/qgis_core.dir/annotations/qgshtmlannotation.cpp.o -c ../src/core/annotations/qgshtmlannotation.cpp
FAILED: src/core/CMakeFiles/qgis_core.dir/annotations/qgshtmlannotation.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++  -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_POSITIONING_LIB -DQT_PRINTSUPPORT_LIB -DQT_SQL_LIB -DQT_SVG_LIB -DQT_WEBKITWIDGETS_LIB -DQT_WEBKIT_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -DTEST_DATA_DIR=\"/tmp/qgis3-20180802-76863-8dubd1/QGIS-final-3_2_1/tests/testdata\" -DWITH_BINDINGS -DWITH_QTWEBKIT -D_HAVE_PTHREAD_ -D_TTY_POSIX_ -Dqgis_core_EXPORTS -I. -I../src/core -Isrc/core -I../src/core/3d -I../src/core/annotations -I../src/core/auth -I../src/core/dxf -I../src/core/effects -I../src/core/expression -I../src/core/fieldformatter -I../src/core/geometry -I../src/core/geocms -I../src/core/geocms/geonode -I../src/core/layertree -I../src/core/layout -I../src/core/locator -I../src/core/metadata -I../src/core/pal -I../src/core/processing -I../src/core/processing/models -I../src/core/providers -I../src/core/providers/memory -I../src/core/raster -I../src/core/renderer -I../src/core/scalebar -I../src/core/symbology -I../src/core/mesh -I../external/nmea -I../external/qextserialport -isystem /usr/local/include -isystem /usr/local/include/spatialindex -isystem /usr/local/opt/gdal2/include -isystem /usr/local/opt/expat/include -isystem /usr/local/opt/sqlite/include -isystem /usr/local/lib/qca-qt5.framework/Headers -isystem /usr/local/include/qt5keychain -iframework /usr/local/opt/qt/lib -isystem /usr/local/opt/qt/lib/QtXml.framework/Headers -isystem /usr/local/opt/qt/lib/QtCore.framework/Headers -isystem /usr/local/opt/qt/./mkspecs/macx-clang -isystem /usr/local/opt/qt/lib/QtGui.framework/Headers -isystem /System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers -isystem /usr/local/opt/qt/lib/QtWidgets.framework/Headers -isystem /usr/local/opt/qt/lib/QtSvg.framework/Headers -isystem /usr/local/opt/qt/lib/QtPrintSupport.framework/Headers -isystem /usr/local/opt/qt/lib/QtNetwork.framework/Headers -isystem /usr/local/opt/qt5-webkit/include -isystem /usr/local/opt/qt5-webkit/include/QtWebKitWidgets -isystem /usr/local/opt/qt5-webkit/include/QtWebKit -isystem /usr/local/opt/qt/lib/QtSql.framework/Headers -isystem /usr/local/opt/qt/lib/QtConcurrent.framework/Headers -isystem /usr/local/opt/qt/lib/QtPositioning.framework/Headers -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include/darwin -isystem /usr/local/Cellar/grass7/7.4.1/grass-base/include -isystem /usr/local/opt/gettext/include -F/usr/local/opt/qt/lib -Wall -Wextra -Wno-long-long -Wformat-security -Wno-strict-aliasing -Wno-return-type-c-linkage -Wno-overloaded-virtual -Qunused-arguments -O2 -g -DNDEBUG -fPIC -fvisibility=hidden   -F/usr/local/lib  -fPIC -std=gnu++11 -MD -MT src/core/CMakeFiles/qgis_core.dir/annotations/qgshtmlannotation.cpp.o -MF src/core/CMakeFiles/qgis_core.dir/annotations/qgshtmlannotation.cpp.o.d -o src/core/CMakeFiles/qgis_core.dir/annotations/qgshtmlannotation.cpp.o -c ../src/core/annotations/qgshtmlannotation.cpp
In file included from ../src/core/annotations/qgshtmlannotation.cpp:26:
In file included from ../src/core/qgswebpage.h:26:
In file included from /usr/local/opt/qt5-webkit/include/QtWebKitWidgets/QWebPage:1:
/usr/local/opt/qt5-webkit/include/QtWebKitWidgets/qwebpage.h:71:29: error: variable has incomplete type 'class QWEBKITWIDGETS_EXPORT'
class QWEBKITWIDGETS_EXPORT QWebPage : public QObject {

The second error seems to be related to pyrcc5

/usr/local/bin/pyrcc5: line 2: exec: pythonw3: not found

pythonw3 is requested when it should be python3 after it runs

gsed -i s/pythonw2.7/python3/g /usr/local/bin/pyrcc5

in the formula.

When installing pyqt, the file pyrcc5 is generated, in the process it first uses python3 and in file it appears python3.7, then it uses python@2 leaving the famous pythonw2.7.

Uninstall pyqt, qt5-webkit and pyqt5-webkit, then rm '/usr/local/bin/pyrcc5' to be doing a cleaner installation.

@luispuerto
Copy link
Collaborator

@fjperini thanks a lot for the help, but now I got another error:

=> cmake -G Ninja -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCMAKE_INSTALL_PREFIX=/usr/local
==> cmake --build . --target all -- -j 8
Last 15 lines from /Users/lpuerto/Library/Logs/Homebrew/qgis3/28.cmake:
[5/4816] /usr/local/Cellar/cmake/3.12.0/bin/cmake -E copy ../src/plugins/qgisplugin.h output/lib/qgis_core.framework/Versions/3.2/Headers/qgisplugin.h
[6/4816] cd /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/plugins/db_manager && /usr/local/bin/pyrcc5 -o /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/plugins/db_manager/resources_rc.py /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/python/plugins/db_manager/resources.qrc
FAILED: python/plugins/db_manager/resources_rc.py
cd /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/plugins/db_manager && /usr/local/bin/pyrcc5 -o /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/plugins/db_manager/resources_rc.py /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/python/plugins/db_manager/resources.qrc
ImportError: No module named site
[7/4816] /usr/local/Cellar/cmake/3.12.0/bin/cmake -E copy ../src/core/expression/qgsexpressionnode.h output/lib/qgis_core.framework/Versions/3.2/Headers/qgsexpressionnode.h
[8/4816] /usr/local/Cellar/cmake/3.12.0/bin/cmake -E copy ../src/core/expression/qgsexpression.h output/lib/qgis_core.framework/Versions/3.2/Headers/qgsexpression.h
[9/4816] /usr/local/Cellar/cmake/3.12.0/bin/cmake -E copy ../src/core/expression/qgsexpressionnodeimpl.h output/lib/qgis_core.framework/Versions/3.2/Headers/qgsexpressionnodeimpl.h
[10/4816] /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++  -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_NO_CAST_TO_ASCII -DWITH_BINDINGS -DWITH_QTWEBKIT -Dqgis_native_EXPORTS -I. -I../src/native -Isrc/native -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include/darwin -isystem /usr/local/Cellar/grass7/7.4.1/grass-base/include -isystem /usr/local/opt/gettext/include -F/usr/local/opt/qt/lib -Wall -Wextra -Wno-long-long -Wformat-security -Wno-strict-aliasing -Wno-return-type-c-linkage -Wno-overloaded-virtual -Qunused-arguments -O2 -g -DNDEBUG -fPIC -fvisibility=hidden   -std=gnu++11 -MD -MT src/native/CMakeFiles/qgis_native.dir/qgsnative.cpp.o -MF src/native/CMakeFiles/qgis_native.dir/qgsnative.cpp.o.d -o src/native/CMakeFiles/qgis_native.dir/qgsnative.cpp.o -c ../src/native/qgsnative.cpp
[11/4816] /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++  -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_NO_CAST_TO_ASCII -DWITH_BINDINGS -DWITH_QTWEBKIT -Dqgis_native_EXPORTS -I. -I../src/native -Isrc/native -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/include/darwin -isystem /usr/local/Cellar/grass7/7.4.1/grass-base/include -isystem /usr/local/opt/gettext/include -F/usr/local/opt/qt/lib -Wall -Wextra -Wno-long-long -Wformat-security -Wno-strict-aliasing -Wno-return-type-c-linkage -Wno-overloaded-virtual -Qunused-arguments -O2 -g -DNDEBUG -fPIC -fvisibility=hidden   -std=gnu++11 -x objective-c++ -MD -MT src/native/CMakeFiles/qgis_native.dir/mac/cocoainitializer.mm.o -MF src/native/CMakeFiles/qgis_native.dir/mac/cocoainitializer.mm.o.d -o src/native/CMakeFiles/qgis_native.dir/mac/cocoainitializer.mm.o -c ../src/native/mac/cocoainitializer.mm
[12/4816] cd /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E echo && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E touch /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/server/sip_serverpart0.cpp /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/server/sip_serverpart1.cpp /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/server/sip_serverpart2.cpp /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/server/sip_serverpart3.cpp && /usr/local/Cellar/sip/4.19.8_5/bin/sip -w -e -x TESTS -x ANDROID -x ARM -x MOBILITY_LOCATION -t WS_MACX -t Qt_5_11_1 -g -o -a /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/qgis.server.api -y /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/output/python/qgis/_server.pyi -j 4 -c /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/server -I /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/server -I /usr/local/share/sip/Qt5 -I /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/python /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/server/server.sip

[13/4816] cd /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E echo && /usr/local/Cellar/cmake/3.12.0/bin/cmake -E touch /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/core/sip_corepart0.cpp /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/core/sip_corepart1.cpp /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/core/sip_corepart2.cpp /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/core/sip_corepart3.cpp && /usr/local/Cellar/sip/4.19.8_5/bin/sip -w -e -x TESTS -x ANDROID -x ARM -x MOBILITY_LOCATION -t WS_MACX -t Qt_5_11_1 -g -o -a /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/qgis.core.api -y /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/output/python/qgis/_core.pyi -j 4 -c /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/core -I /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/core -I /usr/local/share/sip/Qt5 -I /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/python /tmp/qgis3-20180803-20746-ccwrbf/QGIS-final-3_2_1/build/python/core/core.sip

ninja: build stopped: subcommand failed.

If reporting this issue please do so to (not Homebrew/brew or Homebrew/core):
osgeo/osgeo4mac

It's also interesting that my current install of qgis3.2.0, which I also build with homebrew, lacks of python support (as far as I know it didn't)... However, I was able to install qgis2 without a problem.

@luispuerto
Copy link
Collaborator

luispuerto commented Aug 3, 2018

I've decided to delete all the cache and also uninstall pyqt, qt5-webkit and pyqt5-webkit and delete /usr/local/bin/pyrcc5. I got again another build error.

interesting that /usr/local/bin/pyrcc5 isn't is recreated with:

#!/bin/sh
exec pythonw2.7 -m PyQt5.pyrcc_main ${1+"$@"}

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 3, 2018

@luisspuerto you definitely have a problem with QT Webkit. It should be built without problems, even Travis did. Try with HEAD, to discard some things.
This version of qgis3, works correctly, the only thing I had to do is build qdal2-python again since it had been built with python3.6 so that all the modules work.

@nickrobison
Copy link
Collaborator

@luisspuerto It looks like you have two versions of webkit in your path, one from qt5 and one from qt4. The build is pulling headers from both versions and getting confused as to which one to build with.

It seems like you might have an issue with your PATH settings. Did you manually add /usr/local/opt to any include paths?

Can you post the output of brew --doctor? As @fjperini something fishy seems to be going on, but we'll get it sorted out!

@luispuerto
Copy link
Collaborator

luispuerto commented Aug 3, 2018

$ brew doctor                                                                        
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: You have unlinked kegs in your Cellar
Leaving kegs unlinked can lead to build-trouble and cause brews that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  insighttoolkit
  grass7
  matplotlib
$ echo $PATH
/usr/local/opt/llvm/bin:/usr/local/sbin:/Users/lpuerto/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/usr/local/MacGPG2/bin:/opt/X11/bin:/Users/lpuerto/golang/bin:/usr/local/opt/go/libexec/bin

After I run those commands I just uninstalled qt-4 with brew uninstall --ignore-dependencies qt-4 and I'm trying to build again.

@nickrobison
Copy link
Collaborator

nickrobison commented Aug 3, 2018

@luisspuerto Let us know if the build succeeds. Have you manually set any LDFLAGS or CPPFLAGS? That might be the cause of other headers getting dragged in.

@luispuerto
Copy link
Collaborator

@nickrobison as far as I know I don't have those flags set, just for building in R... are part of the R configuration, so I don't think they affect homebrew. Bash and zsh profiles doesn't have any flags.

@luispuerto
Copy link
Collaborator

@nickrobison
Copy link
Collaborator

@luisspuerto It looks like the orfeo5 option is pulling qt4, which is causing the build to break. Can you try to removing that flag and seeing if the error still occurs?

@fjperini We may need to add some additional guards to avoid having the qt4 headers dragging into the environment. Is there a cmake option to manually specific the webkit includes?

@luispuerto
Copy link
Collaborator

I'm trying again without the --with-orfeo5 option, but I've tried before without luck. Let's see what happens now.

@luispuerto
Copy link
Collaborator

luispuerto commented Aug 3, 2018

If it failed I can try without any option just to see if there is problems with the other options also.

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 3, 2018

@nickrobison This option is included in the formula:

args << "-DWITH_QTWEBKIT=#{build.with?("qt5-webkit") ? "TRUE" : "FALSE"}"

From CMakeLists.txt we can see that:

SET (WITH_QTWEBKIT TRUE CACHE BOOL "Enable QtWebkit support")
  IF (WITH_QTWEBKIT)
    ADD_DEFINITIONS(-DWITH_QTWEBKIT)
    MESSAGE(STATUS "Qt WebKit support enabled")
  ELSE (WITH_QTWEBKIT)
    MESSAGE(STATUS "Qt WebKit support DISABLED.")
ENDIF(WITH_QTWEBKIT)

...

IF (WITH_QTWEBKIT)
    FIND_PACKAGE(Qt5WebKit REQUIRED)
    FIND_PACKAGE(Qt5WebKitWidgets REQUIRED)
ENDIF(WITH_QTWEBKIT)

...

IF(WITH_QTWEBKIT)
    SET(OPTIONAL_QTWEBKIT ${Qt5WebKitWidgets_LIBRARIES})
ENDIF(WITH_QTWEBKIT)

We could use(?):

args << "-DWITH_QTWEBKIT=" + Formula["qt-webkit"].opt_prefix + "/lib/cmake/Qt5WebKitWidgets"

@luispuerto
Copy link
Collaborator

now seemed to build correctly, but ...

cmake -G Ninja -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCMAKE_INSTALL_PREFIX=/usr/local
==> cmake --build . --target all -- -j 8
==> cmake --build . --target install -- -j 8
==> Downloading https://gist.githubusercontent.com/fjperini/96bb3654b4d8fd97c343345cd12b6cde/raw/785bea0f9f46f17a626ea31
######################################################################## 100.0%
GRASS 7 GrassUtils.py has been updated
Error: No such file or directory @ rb_sysopen - /usr/local/Cellar/qgis3/3.2.1/QGIS.app/Contents/Resources/python/plugins/processing/algs/otb/OTBUtils.py

🤔 I really don't know what is going on...

@fjperini do you know?

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 3, 2018

@luisspuerto I had a similar error with GRASS, I made a change in

    proc_algs = "Contents/Resources/python/plugins/processing/algs"
    if opts.include?("with-grass") || brewed_grass7?
      grass7 = Formula["grass7"]
      # for core integration plugin support
      envars[:GRASS_PREFIX] = "#{grass7.opt_prefix}/grass-base"
      begin
        inreplace app/"#{proc_algs}/grass7/Grass7Utils.py",
                  "'/Applications/GRASS-7.{}.app/Contents/MacOS'.format(version)",
                  "'#{grass7.opt_prefix}/grass-base'"
        puts "GRASS 7 GrassUtils.py has been updated"
      rescue Utils::InreplaceError
        puts "GRASS 7 GrassUtils.py already updated"
      end
    end

and it worked.

It will have to be reviewed


    if opts.include?("with-orfeo5") || brewed_orfeo5?
      orfeo5 = Formula["orfeo5"]
      begin
        inreplace app/"#{proc_algs}/otb/OTBUtils.py" do |s|
          # default geoid path
          # try to replace first, so it fails (if already done) before global replaces
          s.sub! "OTB_GEOID_FILE) or ''", "OTB_GEOID_FILE) or '#{orfeo5.opt_libexec}/default_geoid/egm96.grd'"
          # default bin and lib path
          s.gsub! "/usr/local/bin", orfeo5.opt_bin.to_s
          s.gsub! "/usr/local/lib", orfeo5.opt_lib.to_s
        end
        puts "ORFEO 5 OTBUtils.py has been updated"
      rescue Utils::InreplaceError
        puts "ORFEO 5 OTBUtils.py already updated"
      end
    end

to solve it.

@luispuerto
Copy link
Collaborator

luispuerto commented Aug 3, 2018

@fjperini I'm eyeballing my formula of qgis3 and I'm seeing the exact same code in it (I fetched your pull request).

proc_algs = "Contents/Resources/python/plugins/processing/algs"
    if opts.include?("with-grass") || brewed_grass7?
      grass7 = Formula["grass7"]
      # for core integration plugin support
      envars[:GRASS_PREFIX] = "#{grass7.opt_prefix}/grass-base"
      begin
        inreplace app/"#{proc_algs}/grass7/Grass7Utils.py",
                  "'/Applications/GRASS-7.{}.app/Contents/MacOS'.format(version)",
                  "'#{grass7.opt_prefix}/grass-base'"
        puts "GRASS 7 GrassUtils.py has been updated"
      rescue Utils::InreplaceError
        puts "GRASS 7 GrassUtils.py already updated"
      end
    end

    if opts.include?("with-orfeo5") || brewed_orfeo5?
      orfeo5 = Formula["orfeo5"]
      begin
        inreplace app/"#{proc_algs}/otb/OTBUtils.py" do |s|
          # default geoid path
          # try to replace first, so it fails (if already done) before global replaces
          s.sub! "OTB_GEOID_FILE) or ''", "OTB_GEOID_FILE) or '#{orfeo5.opt_libexec}/default_geoid/egm96.grd'"
          # default bin and lib path
          s.gsub! "/usr/local/bin", orfeo5.opt_bin.to_s
          s.gsub! "/usr/local/lib", orfeo5.opt_lib.to_s
        end
        puts "ORFEO 5 OTBUtils.py has been updated"
      rescue Utils::InreplaceError
        puts "ORFEO 5 OTBUtils.py already updated"
      end
    end

do I need to make any change to try to fix the new "error"?

@luispuerto
Copy link
Collaborator

PS/ the error I show in
#429 (comment) is after I try to build without --with-orfeo5

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 3, 2018

@luisspuerto I think that if you are not compiling with orfeo5, that error (#429) should not be present.

@luispuerto
Copy link
Collaborator

this is the full compiling output:

$ brew install qgis3 --with-saga-gis-lts --with-r                         
Updating Homebrew...
==> Installing qgis3 from osgeo/osgeo4mac
/usr/local/bin/gsed: couldn't open temporary file /usr/local/bin/sedABvL7S: Operation not permitted
==> Downloading https://github.com/qgis/QGIS/archive/final-3_2_1.tar.gz
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3-3.2.1.tar.gz
==> Downloading https://files.pythonhosted.org/packages/33/bc/fa0b5347139cd9564f0d44ebd2b147ac97c36b2403943dbee8a25fd740
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--homebrew-virtualenv-16.0.0.tar.gz
==> python3 -c import setuptools... --no-user-cfg install --prefix=/private/tmp/qgis3--homebrew-virtualenv-20180803-5173
==> python3 -s /private/tmp/qgis3--homebrew-virtualenv-20180803-51738-6ec4h6/target/bin/virtualenv -p python3 /usr/local
==> Downloading https://files.pythonhosted.org/packages/4d/9c/46e950a6f4d6b4be571ddcae21e7bc846fcbb88f1de3eff0f6dd0a6be5
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--certifi-2018.4.16.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/fc/bb/a5768c230f9ddb03acc9ef3f0d4a3cf93462473795d18e9535498c8f92
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--chardet-3.0.4.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/65/c4/80f97e9c9628f3cac9b98bfca0402ede54e0563b56482e3e6e45c43c49
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--idna-2.7.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/ac/71/ff2fbfa64fca17069ce30fac324533aa686c5cb64e6b5f522faed55884
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--OWSLib-0.16.0.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/d2/12/8ef44cede251b93322e8503fd6e1b25a0249fa498bebec191a5a06adbe
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--cython-0.28.4.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://github.com/jswhit/pyproj/archive/master.zip
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--pyproj-3.2.1.zip
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/a0/b0/a4e3241d2dee665fea11baec21389aec6886655cd4db7647ddf96c3fad
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--python-dateutil-2.7.3.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/ca/a9/62f96decb1e309d6300ebe7eee9acfd7bccaeedd693794437005b9067b
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--pytz-2018.5.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/54/1f/782a5734931ddf2e1494e4cd615a51ff98e1879cbe9eecbdfeaf09aa75
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--requests-2.19.1.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/16/d8/bc6316cf98419719bd59c91742194c111b6f2e85abac88e496adefaf7a
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--six-1.11.0.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/3c/d2/dc5471622bd200db1cd9319e02e71bc655e9ea27b8e0ce65fc69de0dac
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--urllib3-1.23.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/35/fe/e7df7289d717426093c68d156e0fd9117c8f4872b6588e8a8928a0f684
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--coverage-4.5.1.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/94/4a/db842e7a0545de1cdb0439bb80e6e42dfe82aaeaadd4072f2263a4fbed
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--funcsigs-1.0.2.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/00/2b/8d082ddfed935f3608cc61140df6dcbf0edea1bc3ab52fb6c29ae3e81e
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--future-0.16.0.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/0c/53/014354fc93c591ccc4abff12c473ad565a2eb24dcd82490fae33dbf253
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--mock-2.0.0.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/93/46/a389a65237d0520bb4a98fc174fdf6568ad9dcc79b9c1d1f30afc67760
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--nose2-0.7.4.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/3a/20/c81632328b1a4e1db65f45c0a1350a9c5341fd4bbb8ea66cdd98da56fe
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--numpy-1.15.0.zip
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/c8/c3/935b102539529ea9e6dcf3e8b899583095a018b09f29855ab754a20125
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--pbr-4.2.0.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/b2/c1/7bf6c464e903ffc4f3f5907c389e5a4199666bf57f6cd6bf46c17912a1
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--psycopg2-2.7.5.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/9e/a3/1d13970c3f36777c583f136c136f804d70f500168edc1edea6daa72007
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--PyYAML-3.13.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/56/e6/332789f295cf22308386cf5bbd1f4e00ed11484299c5d7383378cf48ba
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--Jinja2-2.10.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/4d/de/32d741db316d8fdb7680822dd37001ef7a448255de9699ab4bfcbdf417
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--MarkupSafe-1.0.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/71/2a/2e4e77803a8bd6408a2903340ac498cb0a2181811af7c9ec92cb70b030
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--Pygments-2.2.0.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> Downloading https://files.pythonhosted.org/packages/fd/ce/aa4a385e3e9fd351737fd2b07edaa56e7a730448465aceda6b35086a0d
Already downloaded: /Users/lpuerto/Library/Caches/Homebrew/qgis3--httplib2-0.11.3.tar.gz
==> /usr/local/Cellar/qgis3/3.2.1/libexec/vendor/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /priv
==> cmake -G Ninja -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCMAKE_INSTALL_PREFIX=/usr/local
==> cmake --build . --target all -- -j 8
==> cmake --build . --target install -- -j 8
==> Downloading https://gist.githubusercontent.com/fjperini/96bb3654b4d8fd97c343345cd12b6cde/raw/785bea0f9f46f17a626ea31
######################################################################## 100.0%
GRASS 7 GrassUtils.py has been updated
Error: No such file or directory @ rb_sysopen - /usr/local/Cellar/qgis3/3.2.1/QGIS.app/Contents/Resources/python/plugins/processing/algs/otb/OTBUtils.py

As you see there isn't a --with-orfeo5 flag

@nickrobison
Copy link
Collaborator

@fjperini The error is occurring because the conditional is checking to see if the orfeo5 directory exists. This means it's actually ignoring the with-orfeo5 option. It looks like that behavior is carried over from the qgis2 so while it's not correct, we may be fine to leave it as is.

@luisspuerto If you remove the `|| brewed_orfeo5?`` from the end of line 522, that should resolve the immediate error you're facing.

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 3, 2018

We are closer 😅 We solved so many things working on this formula!

@nickrobison Do not forget to update gdal2-python. Thank you!

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 3, 2018

A clarification, I installed qgis3 with:

brew install -v qgis3 --with-grass --with-saga-gis-lts

and did not jump the error when verifying if the orfeo5 directory exists. Everything was installed correctly!

I agree with discarding OTB5 and implementing OTB6 in QGIS.

@luisspuerto, did you manage to build qgis3?

@nickrobison
Copy link
Collaborator

@fjperini Do you have orfeo5 installed?

@nickrobison
Copy link
Collaborator

@fjperini If manually setting those CMAKE variables will solve the issue, then that's definitely the correct solution. Happy to merge once that's implemented.

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 6, 2018

@nickrobison Great, I'm in that!
I established everything that CMAKE needs, also this

-DOPTIONAL_QTWEBKIT=#{Formula["qt-webkit"].opt_lib}/cmake/Qt5WebKitWidgets

to avoid the problems that @luisspuerto had with qt4. Was it due to that?

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 6, 2018

@nickrobison I leave this task to you! 😄

  1. Can we make the with-grass flag be without-grass? That way users can still get the bottles even if they want grass support, which I'm sure most people do.

Will you build the bottle for qgis3?

Another thing to see later, is the integration with R.

@nickrobison
Copy link
Collaborator

@fjperini You need to push the CMAKE changes to the formula. The bottle gets built when the PR gets merged.

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 6, 2018

@nickrobison Building! Everything seems to work very well! 🎉

@nickrobison
Copy link
Collaborator

@fjperini You need to push the CMAKE changes before I can merge. The PR is still showing the old commits.

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 6, 2018

@nickrobison Yes I know. I'm just waiting to finish building on my machine. I'll do push!

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 6, 2018

He jumped an error

-- Updating QGIS library paths...
Error: Operation not permitted @ rb_file_s_symlink - (../../../QGIS.app/Contents/Resources/python/qgis, /usr/local/lib/python3.7/site-packages/qgis)
py_lib = python_site_packages
ln_s "../../../QGIS.app/Contents/Resources/python/qgis", py_lib/"qgis"

but it's because I had changed those lines

def python_site_packages
  libexec/"vendor/lib/python3.7/site-packages"
end

to

def python_site_packages
  HOMEBREW_PREFIX/"lib/python#{py_ver}/site-packages"
end

I fix it, build and push.

@jonathanmccormack
Copy link

You could alternatively rely upon some of the built-in Homebrew Language::Python methods:

py_ver = Language::Python.major_minor_version("python3")
py_lib = Language::Python.homebrew_site_packages(py_ver)

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 6, 2018

@nickrobison Ready! I hope it will be built without problems.

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 6, 2018

I solved it, I forgot to change to qt5-webkit.

Error: No available formula with the name "qt-webkit"

Sorry!

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 7, 2018

Solution for the problem reported by @luisspuerto

when this screen appears, a python console icon pops up in the dock... and after I click on cancel or Start GRASS session it disappears and QGIS loads.

@nickrobison qgis3 is fully functional, to merge! 🎉

We did a great job!

@nickrobison nickrobison merged commit 1e96b32 into OSGeo:master Aug 7, 2018
This was referenced Aug 7, 2018
@luispuerto
Copy link
Collaborator

@fjperini I just rebuilt QGIS and builds perfectly... but the grass window still there ☹️

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 7, 2018

@luisspuerto I also had that problem, but after the last changes it worked correctly on my machine. Look!
qgis3

I installed with these options:

brew install qgis3 --with-grass --with-saga-gis-lts --with-r --with-3d

When that popup window opened in the process monitor I noticed that it was calling python@2

Process:         Python [83358]
Path:            /usr/local/Cellar/python@2/2.7.15_1/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python

At least for me, the changes solved that problem.

@luispuerto
Copy link
Collaborator

In mi case it's exactly the same... did you uninstalled the soft(brew uninstall) and then reinstalled or you just brew reinstall? Perhaps that is the problem?

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 8, 2018

@luisspuerto Yes, I uninstalled and installed everything again. I used an application uninstaller, to make sure to erase all files and folders.

@luispuerto
Copy link
Collaborator

luispuerto commented Aug 8, 2018

👍

I'm on it right now... I just brew uninstall and tossed the app in App Cleaner and removed everything. Now it's building. 🤞

PS/ I have an old mac an takes 30' to fully build and the whole process it's like 40' or 35'

@luispuerto
Copy link
Collaborator

Hellooooo.... it's me, again 😂
screen shot 2018-08-08 at 10 33 44

I don't know why... but setting are stuck here... I can check perhaps python2 settings and even uninstall and install it again... or something

@fjperini
Copy link
Collaborator Author

fjperini commented Aug 8, 2018

@luisspuerto That gives work! 😂

You could try that!

Difficult to see the inconvenience you have... working well on my machine.
Look PATH in .bash_profile: export PATH="/usr/local/bin:/usr/local/sbin:$PATH"

@vincentsarago
Copy link
Contributor

Great job people 🎉, worked fine from the first try ;-)

@garrettdashnelson
Copy link

Hero's work ... was just able to install qgis3 (after unlinking pyqt-qt4) directly from Homebrew. Big thanks to everyone who made it happen.

@admercs
Copy link

admercs commented Sep 15, 2018

Nice work! The standard install worked for me:

brew tap osgeo/osgeo4mac
brew install qgis3

The number of dependencies is quite severe though even for the basic installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants