Remove proj_def.dat (#201) #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbevers
reviewed
Dec 27, 2018
kbevers
reviewed
Dec 27, 2018
test/gie/ellipsoid.gie
Outdated
| operation proj=merc | ||
| accept 0 0 | ||
| expect 0 0 | ||
| expect failure errno major_axis_not_given |
There was a problem hiding this comment.
Is this because we now don't have a default ellipsoid?
There was a problem hiding this comment.
I guess that would leave many projections default-less with regards to ellipsoids. It seems to me that +proj=merc not working without adding +ellps=... is a step in the wrong direction. I think setting ellipsoid parameters for GRS80 when initialising a PJ would be a sane default. If +ellps=bessel (or whatever) is set it will obviously be overridden.
There was a problem hiding this comment.
OK, default to ellps=GRS80 per 6bb14fa
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a regression recently added in PROJ master now that cs2cs is using underneath the new ISO19111 code to generate pipeline, which doesn't emit +no_defs, and thus cause issues with CRS using LCC_1SP projections that erroneously use the lat_2=45 default of proj_def.dat