Tests and bugfix for the Orthographic projection #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbevers
force-pushed
the
ortho-tests
branch
4 times, most recently
from
c42e10d
to
6b3616c
Compare
|
98.67% test coverage. I guess that's as good as it gets. @busstoptaktik I need an option in gie that lets me hit those |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases from Snyder added to gie test suite. While doing this I discovered that erroneous points where returned as
(0,0)instead of the expected(HUGE_VAL, HUGE_VAL). This is also fixed in this PR. A error message is also added to the trace log when such transient errors occur.