Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help Frank Help You #1

Closed
proj4-bot opened this issue May 22, 2015 · 1 comment
Closed

Help Frank Help You #1

proj4-bot opened this issue May 22, 2015 · 1 comment
Labels
C: default enhancement invalid P: trivial

Comments

@proj4-bot
Copy link

Reported by Jive on 15 May 2008 20:59 UTC
FrankW puts in a lot of volunteer time wrangling up these osgeo facilities; I am creating this issue to make sure he has hooked up Trac authentication correctly.

This issue can be closed when he is happy.

Migrated-From: https://trac.osgeo.org/proj/ticket/1
@proj4-bot
Copy link
Author

Comment by warmerdam on 15 May 2008 21:00 UTC
Trac operation confirmed, thanks Jody!

This was referenced May 22, 2015
Closed
Closed
Closed
Closed
Closed
@schwehr schwehr mentioned this issue Nov 16, 2017
Closed
schwehr added a commit to schwehr/PROJ that referenced this issue Jul 26, 2018
@schwehr
pj_strerrno(): Change check off err value to avoid undefined behavior.
6be10ac 
src/pj_strerrno.c:96:20: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself
    #0 in pj_strerrno proj/src/pj_strerrno.c:96:20
    OSGeo#1 in (anonymous namespace)::ProjErrnoStringTest_ProjErrnos_Test::TestBody() test/unit/proj_errno_string_test.cpp:47:5

ASAN UndefinedBehaviorSanitizer: signed-integer-overflow

Issue revealed by proj_errno_string_test.cpp add in
OSGeo@b87b591
@schwehr schwehr mentioned this issue Jul 26, 2018
Merged
@nyalldawson nyalldawson mentioned this issue Nov 25, 2019
Closed
@serbinsh serbinsh mentioned this issue Mar 13, 2020
Closed
jkrasting referenced this issue in jkrasting/PROJ May 16, 2020
@jkrasting
Updated sub-projection boundaries for igh_o
68e164a 
- Updates based on Goode, JP, 1925. (DOI: 10.1080/00045602509356949)
- High-latitudes "lobes" added for projections #1 and OSGeo#3
- Central longitude changed to -160
- Added fill reference to docstrings for igh.cpp and igh_o.cpp
@jkrasting jkrasting mentioned this issue May 16, 2020
Merged
rouault added a commit that referenced this issue Jul 23, 2021
@rouault
GeoTIFF grid reading: perf improvements (fixes #2785)
a871ada 
With this commit, and the 2 previous ones, given mytest.cpp
```

int main()
{
    PJ* pj = proj_create(nullptr, "+proj=vgridshift +grids=us_nga_egm96_15.tif");
    for( int i = 0; i < 5*1000*1000; i++)
    {
        PJ_COORD coord;
        coord.lpz.lam = 0;
        coord.lpz.phi = 0;
        coord.lpz.z = 0;
        proj_trans(pj, PJ_FWD, coord);
    }
    return 0;
}
```

we get a x2 speedup

Before:
```
$ PROJ_LIB=data:$HOME/proj/PROJ-data/us_nga LD_LIBRARY_PATH=src/.libs  hyperfine --warmup 1 'taskset -c 11 ./mytest'
Benchmark #1: taskset -c 11 ./mytest
  Time (mean ± σ):      1.950 s ±  0.014 s    [User: 1.945 s, System: 0.005 s]
  Range (min … max):    1.937 s …  1.971 s
```

After:
```
$ PROJ_LIB=data:$HOME/proj/PROJ-data/us_nga LD_LIBRARY_PATH=src/.libs  hyperfine --warmup 1 'taskset -c 11 ./mytest'
Benchmark #1: taskset -c 11 ./mytest
  Time (mean ± σ):     984.4 ms ±   3.1 ms    [User: 977.0 ms, System: 7.2 ms]
  Range (min … max):   979.3 ms … 990.5 ms
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: default enhancement invalid P: trivial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@proj4-bot