Modifications for Intel compilers #1117
Conversation
Also, workaround issue: CMake Error at test/unit/CMakeLists.txt:7 (string): string sub-command REGEX, mode REPLACE needs at least 6 arguments total to command.
|
Is this a fix related to PROJ 5.2 RC1? |
|
yes for 5.2 RC1. After these modifications, all ll tests pass with Intel's |
| else () | ||
| set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fp-model precise") | ||
| set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11") |
There was a problem hiding this comment.
I wonder if we shouldn't set a CMake 3.1 minimum and do this sometime soon (not for this patch, which looks fine IMO)
set (CMAKE_CXX_STANDARD 11)
There was a problem hiding this comment.
I looked into this briefly, and it seems that this was brought in after CMake 2.6.0 (the current minimum version at the top of the file)
Great. Thanks for fixing this!
This especially makes sense once the WKT code is merged. Please add a ticket on this so we remember :-) |
Some changes to allow compilation with Intel compilers
constexpr, but it seemsconstis fine for these contexts