Add a scripts/fix_typos.sh script and correct reported errors #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. This could be implemented as a test on travis. Fail on typos in new code. Or is that a bit too over the top? :) |
American dictionary exceptionalism it is then? |
|
Note that the dictionaries used evolve over time so depending when the script is run results might change |
|
I don't think we should force them for tests to pass, but maybe as part of the docs |
|
That's not a bad idea. I think most contributors these days aren't native english speakers. Spelling errors are bound to happen (I've introduced my fair share it seems). This is a good way to catch them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.