Added myself and Kristian Evers to AUTHORS file; Removed attribution … #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for my 1999 contribution from proj.c
kbevers
reviewed
Aug 18, 2017
| Knud Poder | ||
|
|
||
| Kristian Evers <kreve@sdfe.dk> | ||
| Thomas Knudsen <thokn@sdfe.dk> |
There was a problem hiding this comment.
What is going on with that weird line-ending? Is it because of mixed CR/CR-LF?
There was a problem hiding this comment.
Actually just a missing lf before eof. Also removed some whitespace at eol
|
Probably - recently switched editor and may have fatfingered the setup.
Update upcoming.
Den 18. aug. 2017 7.27 PM skrev "Kristian Evers" <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In AUTHORS
<#558 (comment)>:
> Knud Poder
-
+Kristian Evers ***@***.***>
+Thomas Knudsen ***@***.***>
What is going on with that weird line-ending? Is it because of mixed
CR/CR-LF?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#558 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFWTrYr-WAjH613XXqQrwFqx3QVHcNsvks5sZcmTgaJpZM4O7iV8>
.
|
|
Just noticed that @rouault is missing from the list! |
|
Definitely - and probably a few more: @QuLogic, @micahcochran - anyone else? But despite immodestly adding myself and @kbevers, I did not do so unitl I had stated my intention in a private email to @hobu. And thinking it over again, I believe adding people to the AUTHORS file should probably be the sole privilege of the maintainer? @hobu: Do you agree? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for my 1999 contribution from proj.c