Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fs_receiver in Vendor-specific group #1104

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

leewujung
Copy link
Member

This PR rename the data variable fs_receiver in the Vendor-specific group to receiver_sampling_frequency. This should have been changed around the time of #1019, but somehow didn't get fixed.

@leewujung leewujung added the bug Something isn't working label Jul 31, 2023
@leewujung leewujung added this to the 0.8.0 milestone Jul 31, 2023
@leewujung leewujung requested a review from emiliom July 31, 2023 05:13
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #1104 (0280f8d) into dev (13be688) will decrease coverage by 12.11%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              dev    #1104       +/-   ##
===========================================
- Coverage   78.12%   66.01%   -12.11%     
===========================================
  Files          65       30       -35     
  Lines        6227     3911     -2316     
===========================================
- Hits         4865     2582     -2283     
+ Misses       1362     1329       -33     
Flag Coverage Δ
unittests 66.01% <100.00%> (-12.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
echopype/calibrate/cal_params.py 91.79% <100.00%> (ø)
echopype/convert/set_groups_ek80.py 82.52% <100.00%> (-14.50%) ⬇️

... and 53 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@emiliom emiliom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And BTW I can see that receiver_sampling_frequency occurs in many places in the code, whereas fs_receiver only occurred here.

@leewujung leewujung merged commit 4777f91 into OSOceanAcoustics:dev Jul 31, 2023
3 checks passed
@leewujung leewujung deleted the fix-fs-receiver-in-vend branch July 21, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants