Add test for ES60 spare field decoding issue #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praneethratna
force-pushed
the
test_issue#1195
branch
from
7df0d25
to
7e14abb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1233 +/- ##
===========================================
- Coverage 83.29% 30.92% -52.38%
===========================================
Files 64 64
Lines 5675 5675
===========================================
- Hits 4727 1755 -2972
- Misses 948 3920 +2972
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leewujung
changed the title
leewujung
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
@praneethratna : I verified that the test did run and all looks great! Thanks, I'll merge this now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test case to validate the fix for #1195 which was fixed in #1215 .
CC @leewujung