Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Echodata Platform and Beam_group1 Variables to Compute Depth for EK60/EK80 #1319

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

ctuguinay
Copy link
Collaborator

@ctuguinay ctuguinay commented May 22, 2024

Based on Emilio's #1205 PR. Addresses #790 and #1152.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (9f56124) to head (a1b6ee6).
Report is 53 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1319       +/-   ##
===========================================
+ Coverage   83.52%   93.88%   +10.36%     
===========================================
  Files          64        4       -60     
  Lines        5686      229     -5457     
===========================================
- Hits         4749      215     -4534     
+ Misses        937       14      -923     
Flag Coverage Δ
unittests 93.88% <100.00%> (+10.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctuguinay ctuguinay marked this pull request as ready for review May 23, 2024 17:48
@ctuguinay ctuguinay marked this pull request as draft May 24, 2024 19:52
@ctuguinay ctuguinay marked this pull request as draft May 24, 2024 19:52
@ctuguinay ctuguinay marked this pull request as ready for review May 29, 2024 03:53
@ctuguinay ctuguinay marked this pull request as draft May 29, 2024 03:54
@ctuguinay ctuguinay marked this pull request as ready for review May 30, 2024 01:24
@ctuguinay ctuguinay requested a review from leewujung May 30, 2024 01:24
@ctuguinay
Copy link
Collaborator Author

@leewujung This should be ready for review. The only changes I made from the last time we talked were how to deal with choosing Beam_group1 vs Beam_group2, and interpolating transducer depth time2 to ping_time if and only if they are not equal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
2 participants