Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate.add_depth outputs to work with compute_MVBS #1152

Closed
leewujung opened this issue Sep 1, 2023 · 2 comments · Fixed by #1319
Closed

consolidate.add_depth outputs to work with compute_MVBS #1152

leewujung opened this issue Sep 1, 2023 · 2 comments · Fixed by #1319
Assignees
Milestone

Comments

@leewujung
Copy link
Member

leewujung commented Sep 1, 2023

In the overhaul of compute_MVBS (currently in the working in #1124) the variable water_depth is propagated down in the MVBS dataset. We should review what variables are needed to be propagated down, now that we have standardized the z-axis variables in v0.8.0, and some more improvements/refinement of add_depth will be introduced soon by @emiliom.

Relevant code section:
https://github.com/lsetiawan/echopype/blob/5a963bd397980583827bac2b6ba0b4bdd6ccf8cc/echopype/commongrid/api.py#L164-L166
This is in the PR code so may change in the future.

@leewujung leewujung added this to the 0.8.2 milestone Sep 1, 2023
@emiliom
Copy link
Collaborator

emiliom commented Sep 2, 2023

Note: the variable that's now propagated is called water_level, not water_depth.

@leewujung leewujung removed this from the 0.8.2 milestone Mar 14, 2024
@leewujung leewujung assigned ctuguinay and unassigned emiliom Mar 28, 2024
@leewujung leewujung added this to the v0.8.4 milestone Mar 28, 2024
@leewujung leewujung modified the milestones: v0.8.4, v0.9.0 Apr 18, 2024
@leewujung
Copy link
Member Author

This will be addressed potentially under #1205 or another PR that addresses the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants