Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Contributing guide #1356

Merged
merged 15 commits into from
Jul 19, 2024
Merged

Conversation

leewujung
Copy link
Member

This PR overhauls the Contributing to echopype page:

  • migrate from rst to markdown
  • simplify the structure and text
  • remove sphinx mermaid dependency
  • update all content with recent changes

@leewujung leewujung added the docs label Jul 12, 2024
@leewujung leewujung added this to the v0.9.0 milestone Jul 12, 2024
@leewujung leewujung requested a review from ctuguinay July 12, 2024 21:33
@leewujung
Copy link
Member Author

I was inspired by SciPy yesterday to update the contributing guide!

ctuguinay
ctuguinay previously approved these changes Jul 17, 2024
Copy link
Collaborator

@ctuguinay ctuguinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leewujung This looks good! I just had a few questions and comments

docs/source/contributing.md Outdated Show resolved Hide resolved
docs/source/contributing.md Outdated Show resolved Hide resolved
docs/source/contributing.md Outdated Show resolved Hide resolved

### Versions

ReadTheDocs defaults to having the `stable` version tracking the most recent release and the `main` version tracking the latest changes in the `main` branch of the repository. We follow this pattern for our documentation. See [RTD Versions](https://docs.readthedocs.io/en/stable/versions.html) for more information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our conversation today, when 0.9.0 is released, we're getting rid of stable right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I will delete the stable branch at v0.9.0. The version here are the RTD versions.

docs/source/contributing.md Show resolved Hide resolved
@leewujung
Copy link
Member Author

Thanks @ctuguinay! I think this is ready for another review.

Copy link
Collaborator

@ctuguinay ctuguinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leewujung This looks good thanks!

@ctuguinay ctuguinay merged commit 5eb49b6 into OSOceanAcoustics:main Jul 19, 2024
5 checks passed
@leewujung leewujung deleted the doc_contrib branch July 21, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants