-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update Contributing guide #1356
Conversation
for more information, see https://pre-commit.ci
I was inspired by SciPy yesterday to update the contributing guide! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leewujung This looks good! I just had a few questions and comments
docs/source/contributing.md
Outdated
|
||
### Versions | ||
|
||
ReadTheDocs defaults to having the `stable` version tracking the most recent release and the `main` version tracking the latest changes in the `main` branch of the repository. We follow this pattern for our documentation. See [RTD Versions](https://docs.readthedocs.io/en/stable/versions.html) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From our conversation today, when 0.9.0
is released, we're getting rid of stable
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I will delete the stable
branch at v0.9.0. The version here are the RTD versions.
Co-authored-by: Caesar Tuguinay <87830138+ctuguinay@users.noreply.github.com>
…nto doc_contrib
for more information, see https://pre-commit.ci
Thanks @ctuguinay! I think this is ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leewujung This looks good thanks!
This PR overhauls the
Contributing to echopype
page: