Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug to pass in env_params from parent class method for EK60 #987

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

leewujung
Copy link
Member

This PR fixes the bug that user-provided env params are not correctly taken in in CalibrateEK60.

@leewujung leewujung added this to the 0.6.4.1 milestone Mar 15, 2023
@leewujung leewujung requested a review from emiliom March 15, 2023 20:57
@leewujung leewujung changed the title fix bug to pass in env_params from parent class method Fix bug to pass in env_params from parent class method for EK60 Mar 15, 2023
Copy link
Collaborator

@emiliom emiliom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (after talking to you)!

@leewujung leewujung merged commit 8aca475 into OSOceanAcoustics:dev Mar 15, 2023
@leewujung leewujung deleted the fix-env-ek60-bug branch July 21, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants