firefox: Remove musl support #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kraj Do you still need musl support on firefox? |
|
@cosmo0920 I think the musl support must not be a blocker for upgrades. I am not against to apply patches to support it but someone needs to be actively maintaining it. Also, upgrade it is more important so let's drop them for now. |
|
Wow, thank you! |
|
We have been lagging on musl support, I think it needs to be redone and I would then expect that community also helps in keeping it updated, its not a blocker for now IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #106 removes musl support.
But firefox recipe still supports musl build.
Can we remove musl support from firefox?
We're planning to upgrade firefox recipe to 52esr like as @ashie's work.
This is one of the blockers to upgrade firefox into 52esr from 45esr.