Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] firefox: Update to 52.1.2esr #43

Closed
wants to merge 1 commit into from

Conversation

ashie
Copy link
Collaborator

@ashie ashie commented May 25, 2017

Summary

  • Update Firefox to 52.1.2esr using debian's patchset

  • Update respective l10n recipes for 51.1.2esr

  • Update obsolete configure options in mozilla.bbclass

  • Remove TARGET_CC_ARCH because it causes a configure error:

    mozbuild.configure.options.InvalidOptionError: CC takes 1 value

    In addition this work around seems not necessary anymore because it was
    introduced for built-in nss which isn't used in the current recipe.

Required poky version

  • I confirmed it against poky:master.
  • You can't build it against pyro or former because they doesn't satisfy required nss & nspr versions.

Issues

There is an issue in this pull request, so I added [Do no merge] label to the title.
Although autoconf2.13 is required to build firefox but it never be found without this patch:

because recent bitbake doesn't include host's PATH.

But I think the above patch isn't proper solution, we shouldn't use host's autoconf2.13 directly to respect the poky's change. How should we solve it? Candidates are:

  • Add a recipe to build autoconf2.13 to this layer or poky
  • Add an instruction like this:
    • Add HOSTTOOLS += "autoconf2.13" to your local.conf

* Update Firefox to 51.1.2esr
* Update respective l10n recipes for 51.1.2esr
* Fix obsolete configure options in mozilla.bbclass
* Remove TARGET_CC_ARCH because it causes a configure error:
  > mozbuild.configure.options.InvalidOptionError: CC takes 1 value
  In addition this work around seems not necessary anymore because it was
  introduced for built-in nss which isn't used in the current recipe.
@ashie
Copy link
Collaborator Author

ashie commented Jun 19, 2017

I've found some issues in this PR.

@ashie ashie closed this Jun 19, 2017
@ashie
Copy link
Collaborator Author

ashie commented Jun 19, 2017

@ashie ashie changed the title [Do not merge] firefox: Update to 51.1.2esr [Do not merge] firefox: Update to 52.1.2esr Jul 3, 2017
@bianchi77
Copy link

How can I update it with my 45 version on my computer ? thanks

@otavio
Copy link
Member

otavio commented Jul 3, 2017

@ashie I'd check Arch Linux and Debian to see if they did not port it to a newer autoconf.

@bianchi77 what do you mean?

@kraj
Copy link
Collaborator

kraj commented Jul 3, 2017

We should not be running autoreconf and avoid needing it.

@ashie
Copy link
Collaborator Author

ashie commented Jul 4, 2017

We should not be running autoreconf and avoid needing it.

Oh I see.
Probably it can be realized by adding a patch against auto-generated files.

@ashie
Copy link
Collaborator Author

ashie commented Jul 4, 2017

BTW I'm now investigating another issue.
It seems that drawing tabs is broken on latest poky.

@bianchi77
Copy link

bianchi77 commented Jul 4, 2017 via email

@ashie
Copy link
Collaborator Author

ashie commented Jul 4, 2017

Please try following procedure:

$ cd meta-browser
$ git remote add ashie https://github.com/ashie/meta-browser.git
$ git fetch --all
$ git checkout firefox-52.1.2esr-2

@bianchi77
Copy link

bianchi77 commented Jul 4, 2017 via email

@bianchi77
Copy link

bianchi77 commented Jul 4, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants