Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Search map feature #259

Merged
merged 36 commits into from
Sep 14, 2023
Merged

[PR] Search map feature #259

merged 36 commits into from
Sep 14, 2023

Conversation

solderq35
Copy link
Contributor

@solderq35 solderq35 commented Sep 12, 2023

Issue

#250

Work Done

image

Work Still Needed

QoL

Styling

  • find better places to put search input field, results
  • dropdown for results, hide when not typing (mimic standard search bar ui)
  • dynamic search results height
  • maximum amount of results (10 or 20?)
  • overflow scroll in results?
  • mobile styling in general

@solderq35
Copy link
Contributor Author

solderq35 commented Sep 12, 2023

Desktop

image

Mobile

image

Next Steps

  • should height of the SideMenu respond to number of search results? right now looks too tall
  • sidemenu too close to bottom of screen on mobile
  • zooms in on text input on mobile, leading to zoom issues
    • look into bigger text input on mobile?
    • alternatively, have something to zoom back out on mobile?
    • re-center map around building (both mobile and desktop? would include zoom)
    • mobile has parts of map out of range as noted earlier

@solderq35
Copy link
Contributor Author

idea - scrolling ticker ui on long building names

@solderq35
Copy link
Contributor Author

solderq35 commented Sep 14, 2023

Summary of Changes

Highlights chosen building in yellow on both desktop (hover) and mobile (click, technically hover.

Re-centers map around the building you clicked.

No longer automatically zooms in when typing input on mobile.

Desktop

image

image

Mobile

image

image

@solderq35 solderq35 merged commit a31b229 into master Sep 14, 2023
3 checks passed
@s-egge s-egge deleted the search-map-feature branch July 1, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant