Gesture interface merge #181
Conversation
| namespace osvr { | ||
| namespace common { | ||
|
|
||
| #define MAX_REGISTRY_SIZE 100 |
There was a problem hiding this comment.
Nooo! Big code guideline violation. (And use an enlargeable structure instead of having a fixed size)
|
Notes about Leap Motion gestures: OSVR/OSVR-Leap-Motion#5 |
|
The places where an Interface pointer is being held, should instead be using an |
|
This pull request is ready to be merged |
|
OK - blocked on #218 - after that is finished (unit tests) and merged, this can be rebased on top of the new master. Most of all the "little" pieces that are independent have been pulled out and merged separately, so there will be ample use of |
|
I completed unit tests merged #218 yesterday and rebased gesture branch on top of master. Also I fixed a few things that wouldn't let it build and some compiler errors. |
|
Will require fix to adjust for 0a63fd5 once that branch is merged. Sorry... |
No more overriding operator& or providing non-const value accessors or implicit conversion. It's also now properly in a namespace, and uses traits classes to determine the underlying value type as well as the "invalid/empty" sentinel value.
…compiler warnings
No description provided.