Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0x15-V7-Error-Logging.md is fairly light #1626

Closed
jmanico opened this issue May 23, 2023 · 5 comments
Closed

0x15-V7-Error-Logging.md is fairly light #1626

jmanico opened this issue May 23, 2023 · 5 comments
Assignees
@jmanico
Labels
7) PR in non-master branch V7 Temporary label for grouping logging related issues _5.0 - prep This needs to be addressed to prepare 5.0

Comments

@jmanico
Copy link
Member

jmanico commented May 23, 2023 •
edited
Loading

I suggest we add other security logging events from the logging vocab cheatsheet like:

authn_impossible_travel[:userid,region1,region2]
authn_token_reuse[:userid,tokenid]
authz_fail[:userid,resource]
upload_validation_failure[filename,(virusscan|imagemagick]
malicious_extraneous:[userid|IP,inputname,useragent]
malicious_attack_tool:[userid|IP,toolname,useragent]
malicious_cors:[userid|IP,useragent,referer]
malicious_direct_reference:[userid|IP, useragent]
@elarlang
Copy link
Collaborator

elarlang commented May 23, 2023 •
edited
Loading

Can you please create requirements of them?

Related to #1444 (comment)

Fileupload has separate issue opened: #1622

@elarlang elarlang added 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet V7 Temporary label for grouping logging related issues labels May 23, 2023
@tghosth tghosth added _5.0 - prep This needs to be addressed to prepare 5.0 4b Major-rework These issues need to be part of a full chapter rework and removed 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet labels Jul 10, 2023
@elarlang elarlang mentioned this issue Nov 26, 2023
Closed
@tghosth
Copy link
Collaborator

tghosth commented May 2, 2024

Yeah I think we are going for less detail rather than more detail :) We can also include a link to the logging vocab cheatsheet :)

@tghosth
Copy link
Collaborator

tghosth commented May 2, 2024

I'll do this when #1944 is merged.

Change "such as the OWASP Logging Cheat Sheet for specific implementation details."

to "such as the OWASP Logging Cheat Sheet and the OWASP Application Logging Vocabulary Cheat Sheet for specific implementation details"

Add at the bottom

* [OWASP Application Logging Vocabulary Cheat Sheet](https://cheatsheetseries.owasp.org/cheatsheets/Logging_Vocabulary_Cheat_Sheet.html)

@set-reminder in 5 days add this into V7.

@octo-reminder Octo Reminder
Copy link

octo-reminder bot commented May 2, 2024

⏰ Reminder
Tuesday, May 7, 2024 12:00 AM (GMT+02:00)

in add this into V7.

@tghosth tghosth added 4a) Waiting for another This issue is waiting for another issue to be resolved and removed 4b Major-rework These issues need to be part of a full chapter rework labels May 2, 2024
tghosth added a commit that referenced this issue May 2, 2024
@tghosth
Add info on Logging Vocabulary Cheat Sheet to resolve #1626
a0faa6b
@tghosth tghosth added 7) PR in non-master branch and removed 4a) Waiting for another This issue is waiting for another issue to be resolved labels May 2, 2024
@octo-reminder Octo Reminder
Copy link

octo-reminder bot commented May 6, 2024

🔔 @tghosth

in add this into V7.

@tghosth tghosth closed this as completed in 421cc17 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmanico jmanico

Labels
7) PR in non-master branch V7 Temporary label for grouping logging related issues _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmanico @tghosth @elarlang