-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed spellings and grammatical mistakes #243
Conversation
i am onto fixing all the spelling mistakes in owasp cheatsheet project please run a diff bw old doc and my doc youll see a lot of changes git unfortunately isnt showing bcoz I copied the raw and used Grammarly and other tools to check for errors and then re-pasted the fixed version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of these changes are good, but I've made comments on some that need looking at again. Please be very careful running automated grammar checkers and make sure you're manually verifying the results - because some of the changes suggested are incorrect, and some of them are changing the actual meaning of sentences.
Grammar tools tend to be a bit unreliable for technical content, as we often use words in ways that don't quite match normal english grammar.
let me redo it all it seems like there was a mistake of versions i pasted vs what i fixed |
Yes i will
…On Thu, 24 Oct, 2019, 4:54 PM mackowski, ***@***.***> wrote:
@sheerazali19 <https://github.com/sheerazali19> can you please introduce
changes requested by @jsoref <https://github.com/jsoref> and @rbsec
<https://github.com/rbsec>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#243?email_source=notifications&email_token=ACSJDUT2NAK7UQDWVQM4PSLQQGAWVA5CNFSM4I5FLI32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEV3NA#issuecomment-545873332>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACSJDUSSQLP6XJ4MZK7ZR2LQQGAWVANCNFSM4I5FLI3Q>
.
|
Couldn't find time had a tight schedule and deadlines to meet
…On Thu, 24 Oct, 2019, 5:18 PM Sheeraz Ali, ***@***.***> wrote:
Yes i will
On Thu, 24 Oct, 2019, 4:54 PM mackowski, ***@***.***> wrote:
> @sheerazali19 <https://github.com/sheerazali19> can you please introduce
> changes requested by @jsoref <https://github.com/jsoref> and @rbsec
> <https://github.com/rbsec>?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#243?email_source=notifications&email_token=ACSJDUT2NAK7UQDWVQM4PSLQQGAWVA5CNFSM4I5FLI32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEV3NA#issuecomment-545873332>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACSJDUSSQLP6XJ4MZK7ZR2LQQGAWVANCNFSM4I5FLI3Q>
> .
>
|
No problem :) I just wanted to check the status. |
@mackowski @ThunderSon I've fixed the open comments on this by pushing to @sheerazali19's branch - so this should be good to merge now. |
This PR should be ready to merge, all review comments have been tackled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ThunderSon for updating this PR!
i am onto fixing all the spelling mistakes in owasp cheatsheet project please run a diff bw old doc and my doc youll see a lot of changes git unfortunately isnt showing bcoz I copied the raw and used Grammarly and other tools to check for errors and then re-pasted the fixed version
Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.
Please make sure that for your contribution:
If your PR is related to an issue. Please end your PR text with the following line:
This PR covers issue #.
Thank you again for your contribution 😃