Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed spellings and grammatical mistakes #243

Merged
merged 5 commits into from
Apr 15, 2020
Merged

Conversation

pwnmeow
Copy link
Contributor

@pwnmeow pwnmeow commented Oct 3, 2019

i am onto fixing all the spelling mistakes in owasp cheatsheet project please run a diff bw old doc and my doc youll see a lot of changes git unfortunately isnt showing bcoz I copied the raw and used Grammarly and other tools to check for errors and then re-pasted the fixed version

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double check the file for other mistakes in order to fix all the issue on the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see policy here.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to website have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g.: defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue. Please end your PR text with the following line:

This PR covers issue #.

Thank you again for your contribution 😃

i am onto fixing all the spelling mistakes in owasp cheatsheet project please run a diff bw old doc and my doc youll see a lot of changes git unfortunately isnt showing bcoz I copied the raw and used Grammarly and other tools to check for errors and then re-pasted the fixed version
Copy link
Contributor

@rbsec rbsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of these changes are good, but I've made comments on some that need looking at again. Please be very careful running automated grammar checkers and make sure you're manually verifying the results - because some of the changes suggested are incorrect, and some of them are changing the actual meaning of sentences.

Grammar tools tend to be a bit unreliable for technical content, as we often use words in ways that don't quite match normal english grammar.

cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
@rbsec rbsec added the WAITING_UPDATE Reserved to PR: Indicates that the core team is waiting update from the author of the PR. label Oct 3, 2019
@pwnmeow
Copy link
Contributor Author

pwnmeow commented Oct 3, 2019

let me redo it all it seems like there was a mistake of versions i pasted vs what i fixed

cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
@mackowski
Copy link
Collaborator

@sheerazali19 can you please introduce changes requested by @jsoref and @rbsec?

@pwnmeow
Copy link
Contributor Author

pwnmeow commented Oct 24, 2019 via email

@pwnmeow
Copy link
Contributor Author

pwnmeow commented Oct 24, 2019 via email

@mackowski
Copy link
Collaborator

No problem :) I just wanted to check the status.

@rbsec
Copy link
Contributor

rbsec commented Feb 22, 2020

@mackowski @ThunderSon I've fixed the open comments on this by pushing to @sheerazali19's branch - so this should be good to merge now.

@rbsec rbsec removed the WAITING_UPDATE Reserved to PR: Indicates that the core team is waiting update from the author of the PR. label Feb 22, 2020
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Authentication_Cheat_Sheet.md Outdated Show resolved Hide resolved
@ThunderSon
Copy link
Contributor

This PR should be ready to merge, all review comments have been tackled.

Copy link
Collaborator

@mackowski mackowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ThunderSon for updating this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants