Add cli option to determine output directory when extracting archives with pysapcar #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 3, 2018 14:56
More pythonic, plus outdir option needs join() which would be very ambiguous without context.
Methods to static, redundant dirname check, print statement to logger.debug().
No changes to functionality, just future proofing.
mkdir barfs if archive contains /foo/bar/bash but not the intermediate directory /foo/bar. makedirs creates intermediate directories as well as the leaf dir.
|
Thanks, great addition and seem to be working great for this use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23. Also fixes some linter naggings, upgrades deprecated optparse to argparse and handles some extraction corner cases without printing stack trace.