Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli option to determine output directory when extracting archives with pysapcar #24

Merged
merged 6 commits into from Jul 3, 2018
Merged

Add cli option to determine output directory when extracting archives with pysapcar #24

merged 6 commits into from Jul 3, 2018

Commits on Jul 3, 2018

  1. Use os.path functions from path directly 

    More pythonic, plus outdir option needs join() which would be very
ambiguous without context.
    Oula Kuuva committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    b0af986 View commit details
    Browse the repository at this point in the history

  2. Fix some cosmetic issues to silence the linter 

    Methods to static, redundant dirname check, print statement to
logger.debug().
    Oula Kuuva committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    bc64316 View commit details
    Browse the repository at this point in the history

  3. Replace deprecated optparse with argparse 

    No changes to functionality, just future proofing.
    Oula Kuuva committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    94d4f17 View commit details
    Browse the repository at this point in the history

  4. Add option for specifying outdir for extraction

    Oula Kuuva committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    8018a21 View commit details
    Browse the repository at this point in the history

  5. Use makedirs instead of mkdir when extracting 

    mkdir barfs if archive contains /foo/bar/bash but not the intermediate
directory /foo/bar. makedirs creates intermediate directories as well as
the leaf dir.
    Oula Kuuva committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    9f53a2f View commit details
    Browse the repository at this point in the history

  6. Handle OSErrors gracefully while extracting

    Oula Kuuva committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    12ac48c View commit details
    Browse the repository at this point in the history