Adding Challenge 28 #690
Merged
Adding Challenge 28 #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@commjoen @bendehaan |
commjoen
reviewed
Mar 10, 2023
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge28.java
Outdated
Show resolved
Hide resolved
commjoen
requested changes
Mar 10, 2023
There was a problem hiding this comment.
Hi @puneeth072003 ! Your first challenge! thank you!
Here are some feedback items based on the textual and linting results. You can, for each suggestion click on "commit suggestion" or "add suggestion to batch"in the files overview, and then quickly add the recommended changes.
After that, let's file the issue :D !
Love this!
src/test/java/org/owasp/wrongsecrets/challenges/docker/Challenge28Test.java
Outdated
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge28.java
Outdated
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge28.java
Outdated
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge28.java
Outdated
Show resolved
Hide resolved
src/test/java/org/owasp/wrongsecrets/challenges/docker/Challenge28Test.java
Outdated
Show resolved
Hide resolved
src/test/java/org/owasp/wrongsecrets/challenges/docker/Challenge28Test.java
Outdated
Show resolved
Hide resolved
…ge28.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28Test.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28Test.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28Test.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
commjoen
approved these changes
Mar 11, 2023
There was a problem hiding this comment.
Lgtm! Thank you @puneeth072003 !
@bendehaan would you be able to do one more round of textual reviewing on it please?
bendehaan
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Adding a new challenge 28 as asked in issue #423 completing the Part 1 of that issue
Relations
issue #423
Checklist: