Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Challenge 29 #697

Merged
merged 23 commits into from
Apr 2, 2023
Merged

Addition of Challenge 29 #697

merged 23 commits into from
Apr 2, 2023

Conversation

puneeth072003
Copy link
Contributor

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Submission of challlenge as per the issue #423 part 4 .i.e,

  • have a screenshot in an issue (CloseD) to have the secret inside accidentaly "my passphrase is broken" and show the passphrase in the screenshot for a GPG unlock action.

Relations

Relates #423 and It is continuation of PR #690

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

@puneeth072003
Copy link
Contributor Author

puneeth072003 commented Mar 11, 2023

Pending task:

  • Still have to file a bug report containing the screenshot of the passcode

@puneeth072003
Copy link
Contributor Author

Pending task:

  • Still have to file a bug report containing the screenshot of the passcode

Hey @commjoen, Shall I add it now?

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow @puneeth072003 my man! I remember the days when you created your first code-block and now you are taking RSA encryption/decryption head on!
You go sir!
Just a few more changes, and i say; let's go!

puneeth072003 and others added 4 commits April 1, 2023 22:30
…ge29.java

Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
@puneeth072003
Copy link
Contributor Author

@commjoen How can I fix this test failure [Java spotbugs, checkstyle and testing / lint javacode (pull_request)]
I even removed all the whitespaces of the specified block but still it is not yet solved......any suggestions?

@commjoen
Copy link
Collaborator

commjoen commented Apr 1, 2023

@commjoen How can I fix this test failure [Java spotbugs, checkstyle and testing / lint javacode (pull_request)] I even removed all the whitespaces of the specified block but still it is not yet solved......any suggestions?

Given it says

Error:  /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:39:29: WhitespaceAround: '{' is not preceded with whitespace. [WhitespaceAround]
Error:  /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:9: WhitespaceAround: '}' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3) [WhitespaceAround]
Error:  /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:10: WhitespaceAround: 'catch' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3) [WhitespaceAround]
Error:  /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:10: WhitespaceAround: 'catch' is not preceded with whitespace. [WhitespaceAround]
Error:  /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:28: WhitespaceAround: '{' is not preceded with whitespace. [WhitespaceAround]

The easiest is just to auto-format using your editor (select "code"-->"reformat file") and you should be good

@puneeth072003
Copy link
Contributor Author

@commjoen How can I fix this test failure [Java spotbugs, checkstyle and testing / lint javacode (pull_request)] I even removed all the whitespaces of the specified block but still it is not yet solved......any suggestions?

Given it says

Error:  /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:39:29: WhitespaceAround: '{' is not preceded with whitespace. [WhitespaceAround]
Error:  /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:9: WhitespaceAround: '}' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3) [WhitespaceAround]
Error:  /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:10: WhitespaceAround: 'catch' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3) [WhitespaceAround]
Error:  /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:10: WhitespaceAround: 'catch' is not preceded with whitespace. [WhitespaceAround]
Error:  /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:28: WhitespaceAround: '{' is not preceded with whitespace. [WhitespaceAround]

The easiest is just to auto-format using your editor (select "code"-->"reformat file") and you should be good

Fixed: it's good to go I think only thing left top do is to create issue

@commjoen
Copy link
Collaborator

commjoen commented Apr 2, 2023

Almost: please remove any changes to

  • src/main/java/org/owasp/wrongsecrets/challenges/Challenge.java
  • src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @bendehaan want to check the text?

commjoen and others added 2 commits April 2, 2023 14:36
Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>
@commjoen commjoen merged commit 9d6726c into OWASP:master Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants