-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of Challenge 29 #697
Conversation
Pending task:
|
updation
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java
Outdated
Show resolved
Hide resolved
updation
updation
updation
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java
Fixed
Show resolved
Hide resolved
Hey @commjoen, Shall I add it now? |
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java
Fixed
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java
Fixed
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow @puneeth072003 my man! I remember the days when you created your first code-block and now you are taking RSA encryption/decryption head on!
You go sir!
Just a few more changes, and i say; let's go!
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java
Outdated
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java
Fixed
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java
Fixed
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java
Outdated
Show resolved
Hide resolved
…ge29.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
@commjoen How can I fix this test failure [Java spotbugs, checkstyle and testing / lint javacode (pull_request)] |
Given it says Error: /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:39:29: WhitespaceAround: '{' is not preceded with whitespace. [WhitespaceAround]
Error: /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:9: WhitespaceAround: '}' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3) [WhitespaceAround]
Error: /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:10: WhitespaceAround: 'catch' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3) [WhitespaceAround]
Error: /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:10: WhitespaceAround: 'catch' is not preceded with whitespace. [WhitespaceAround]
Error: /home/runner/work/wrongsecrets/wrongsecrets/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java:83:28: WhitespaceAround: '{' is not preceded with whitespace. [WhitespaceAround] The easiest is just to auto-format using your editor (select "code"-->"reformat file") and you should be good |
Fixed: it's good to go I think only thing left top do is to create issue |
Almost: please remove any changes to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @bendehaan want to check the text?
Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>
What kind of changes does this PR include?
Description
Submission of challlenge as per the issue #423 part 4 .i.e,
Relations
Relates #423 and It is continuation of PR #690
References
Checklist: