vat message for b2b users with valid ustid #495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mparienti
force-pushed
the
fix-do-not-bill-vat-if-valid-vatid
branch
from
2516650
to
f87206f
Compare
|
|
mparienti
force-pushed
the
fix-do-not-bill-vat-if-valid-vatid
branch
from
f87206f
to
b4bcae7
Compare
|
just realized that there might be a better way to fix this by using getUserVat from VatSelector class |
|
Hello @keywan-ghadami-oxid, thanks for your pull request. Are you planning to make further improvements on this pull request? |
|
Hello @keywan-ghadami-oxid, some points to update the pull request:
|
|
Thank you for your pull request. It was adjusted a little by latest code, and I have merged it at fa16a93. Have a nice day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vat messages say vat is included in the price but that's wrong
https://bugs.oxid-esales.com/view.php?id=6516