Fix for select elements appearing twice (bug #7007); removed remnants of Bootstrap Select #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to Wave 1.2.0
Wave-Update
Sync with master
martin-hofer
changed the title
|
Before: After: |
Sieg
pushed a commit
that referenced
this pull request
Aug 28, 2019
….js and four TPL files Related #63
Sieg
pushed a commit
that referenced
this pull request
Aug 28, 2019
Sieg
pushed a commit
that referenced
this pull request
Aug 28, 2019
|
Hey @martin-hofer! Great job on fixing those issues! Looks good! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you choose "Germany" in, for example, the register form, the "State" select field pops up. At least that's what should happen, but instead we get two: The normal select field and below it another one with an empty flyout.
Bug #7007 describes the same problem on the contact page:
https://bugs.oxid-esales.com/view.php?id=7007
The reason for this behavior is that Bootstrap Select wasn't completely removed when migrating from Flow to Wave.
I removed jqBootstrapSelect from the Gruntfile (and thus from script.min.js) as well as references to the class "selectpicker" from several TPL files.