Add active state condition befor adding controllers to database:

[bissie]

When fixing modules that has metadata Version > 2 and define controllers, this controllers are added to aModulesControllers in oxconfig.
This behavior is correct for active modules but when adding controllers for inactive modules, than activating it lead to an exception, as such controllers are already configured. In a second step activation works.

Steps to reproduce:
Set up shop including oxid console.
Test activation/deactivation for paypal
Run php vendor/bin/oxid modules:fix --all from installation path
Try to activate paypal module again.

BTW, changes looks strange but simple surround code with if($module->isActive()){}

[alfredbez]

Thank you @bissie for the fix!

BTW, changes looks strange but simple surround code with if($module->isActive()){}

Diff looks a lot cleaner when you ignore whitespace changes: https://github.com/OXIDprojects/oxid-console/pull/12/files?w=1

---

It would be cool to have more tests for bugs like this.

[keywan-ghadami-oxid]

this was also fixed in
https://github.com/OXIDprojects/oxid-module-internals
the fix:states command from the console will be removed in the next major version because the functionality to fix modules will be maintained in that module (to be available in all console implementations)