Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marine] Integration into OED #202

Open
8 of 11 tasks
johcarter opened this issue Jun 28, 2024 · 4 comments
Open
8 of 11 tasks

[Marine] Integration into OED #202

johcarter opened this issue Jun 28, 2024 · 4 comments
Assignees
Labels
major major release (breaking change)

Comments

@johcarter
Copy link
Contributor

johcarter commented Jun 28, 2024

Description

Tasks to integrate the Marine Cargo exposure class into OED
Fields will be a selected subset of property fields plus a few new ones.

  • Add as a separate column in OED fields
  • Agree optional fields
  • Review financial fields
  • Add CommoditySchemeXX (CR), CommodityCodeXX (CR) and CommodityVintageXX (O) to location file
  • Add new range of occupancy codes
  • Include new occupancy codes in Version tab

Reasons for change

To support Marine Cargo as a distinct exposure class in integrated OED v4 and later.

Scope of change

  • Specification
  • Location File
  • Accounts File
  • Reinsurance Scope
  • Reinsurance Info

Impact of change

Breaking only as part of major specification restructuring.

Data type, default values, are blanks allowed, list valid values

Commodity codes to categorize type of cargo/stock
The initial scheme is HS22, or user defined pre-fixed with X.

https://www.wcoomd.org/en/topics/nomenclature/instrument-and-tools/hs-nomenclature-2022-edition.aspx

Field Name Data type Default values Valid values
CommoditySchemeXX varchar(5) n/a
CommodityCodeXX varchar(10) n/a
CommodityVintageXX smallint 0 [0,)

New occupancy code list to be proposed (work in progress).

@johcarter johcarter added the major major release (breaking change) label Jun 28, 2024
@johcarter johcarter self-assigned this Jun 28, 2024
@johcarter
Copy link
Contributor Author

Fallback occupancy code for new marine cargo codes set to 1100 general commercial in 'Versioning' table, unless anyone can think of a more suitable fallback ? fyi @MattDonovan82

@johcarter
Copy link
Contributor Author

There are some outstanding tasks to do which are now blocking the release.

Given that marine cargo has no special field requirements (other than commodity fields, which have been added for property) and is a subset of property fields, I think we could backlog them and go with marine cargo as part of the property class for v4, and perhaps give a marine cargo example in the examples folder as guidance for users.

We could later add a separate column for marine cargo when the requirement to split it out as a separate class is proven. What do you think @MattDonovan82 ?

johcarter added a commit that referenced this issue Aug 15, 2024
@johcarter
Copy link
Contributor Author

Reference file for implementation:

OED_Marine_Cargo_Data_Spec_v0.0.10.xlsx

A few changes were made to the list of fields as follows;

Added

  • AccDed6All
  • AccLimit6All
  • PolDed6All
  • PolLimit6All
  • AccDed2Other
  • AccLimit2Other
  • PolDed2Other
  • PolLimit2Other
  • LayerNumber
  • LayerAttachment
  • LayerLimit
  • LayerParticipation
  • CededPercent (ri_scope)

Reason: omissions from original list which should be included.

Removed

  • LocPeril

Reason: this field is only needed for location specific terms and conditions i.e. LocDed{}, LocLimit{} fields, which are all n/a / not supported

@MattDonovan82
Copy link
Contributor

Following further conversations, adding a marine cargo column now was agreed as it explicitly sets out what fields for marine cargo are supported (even if that doesn't differentiate from the property fields at the moment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major major release (breaking change)
Projects
Status: Done
Status: Todo
Status: Agreed and ready
Development

No branches or pull requests

2 participants