-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oed v3.1 collected non-breaking changes #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues added for OED v3.1 anything I've missed @johcarter ?
Updates made for v3.1 highlighted in yellow.
Removed pdf doc as it was out of date and all chapters are being maintained as .rst anyway.
updates made to the 'versioning' tab
Updates to Readme for versioning and back compatibility
* added policy conditions documentation * moved conditions into new section * example fixes * example 10 and 11 * example 10 fix * clarifications * update following MD review * added loss examples * corrections and more loss examples * few corrections * spacing * edits following AK review * more corrections
This was
linked to
issues
Nov 9, 2023
johcarter
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross-checked all spec changes against changelog. @MattDonovan82 to also review and approve
removing file as made small changes to data brackets
Adding updated spec of v3.1
removing blank file
MattDonovan82
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all changes look good to me.
changes to NumberofStoreys data range
sambles
added a commit
that referenced
this pull request
Nov 9, 2023
* base conditional requiremet on oed source type (#159) * base conditional requiremet on oed source type * CR level 1 don't create requirements * Update README.md Fix #147 * Update README.md updated major and minor descriptions * Update README.md a couple more small updates to the read me * Oed v3.1 collected non-breaking changes (#167) * added paragraph on optional versus CR filter fields * Update Changelog.rst Issues added for OED v3.1 anything I've missed @johcarter ? * Add files via upload Updates made for v3.1 highlighted in yellow. * Delete OpenExposureData/Docs/Open_Exposure_Data_v2.1.0.pdf Removed pdf doc as it was out of date and all chapters are being maintained as .rst anyway. * Add files via upload * Delete OpenExposureData/Docs/OED_v3.1_fallback codes.xlsx * Delete OpenExposureData/Docs/OpenExposureData_Spec_v3.1.xlsx * Add files via upload updates made to the 'versioning' tab * Delete OpenExposureData/Docs/OpenExposureData_Spec_v3.1.xlsx * Add files via upload * Add files via upload * Update README.md Updates to Readme for versioning and back compatibility * Split policy conditions documentation into a new section (#169) * added policy conditions documentation * moved conditions into new section * example fixes * example 10 and 11 * example 10 fix * clarifications * update following MD review * added loss examples * corrections and more loss examples * few corrections * spacing * edits following AK review * more corrections * reviewed excel spec and replaced previous version with 3.1 version * revert implentation of issue 162 (breaking) and added a few issues to changelog * Delete OpenExposureData/Docs/OpenExposureData_Spec.xlsx removing file as made small changes to data brackets * Create Spec * Add files via upload Adding updated spec of v3.1 * Delete OpenExposureData/Docs/Spec removing blank file * Add files via upload * Add files via upload changes to NumberofStoreys data range --------- Co-authored-by: Joh Carter <johanna.carter@oasislmf.org> Co-authored-by: MattDonovan <56030661+MattDonovan82@users.noreply.github.com> * Versioning info (#166) * Added versioning sheet * added versioning sheets * versioning info grouped by version * removed the unused 'Other' category * if no versioning info, create empty dict * example schema for adding versioning information * Fix CI testing * added codes to revert to OED v2.2 and v2.0 * Removed test schema * fallback 1256 and 1305 -> 1104 & 5503 -> 5501 * 5309, 5310 -> 5100 * new codes (agriculture) * Fix CD release * Disable guard * Revert "Disable guard" This reverts commit 0b14734. * Replaced spec xlsx file * Corrected field "number of storeys" * Add files via upload --------- Co-authored-by: Sam Gamble <hexadessa@gmail.com> --------- Co-authored-by: Stephane Struzik <34556337+sstruzik@users.noreply.github.com> Co-authored-by: Marco Tazzari <6020226+mtazzari@users.noreply.github.com> Co-authored-by: MattDonovan <56030661+MattDonovan82@users.noreply.github.com> Co-authored-by: Joh Carter <johanna.carter@oasislmf.org> Co-authored-by: Nicola Cerutti <94574085+ncerutti@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oed v3.1 collected non-breaking changes