Objects defined in global.R moved to the package #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* They are used by many functions inside the package so they belong there (R CMD check was not happy, for good reasons).
riccardoporreca
changed the title
fvitalini
added a commit
that referenced
this pull request
Aug 15, 2019
* Objects defined in global.R moved to the package. (#161) * clean up tooltips
fvitalini
added a commit
that referenced
this pull request
Sep 6, 2019
* Review createHazardMap. (#162) * Technical fixes: Reactive inputs, callModule not inside observer (!). * Improve and fix map/markers creation, including better reactive programming. * shinycssloaders::withSpinner for the rendering, withModalSpinner for reading the data. * Fix mixed module documentation between UI and server functions, the same should be fixed across many other modules, at minimum to not have duplicated `id` param (devtools::check_man()). * Feature/fix globals (#163) * Objects defined in global.R moved to the package. (#161) * clean up tooltips * fix pop-up in all map views * clean up * updated description * requesting shinyjs from github and fixing commit for reference * replaced onclick with observeEvent * removed suplicate entry in description file * fix typo * leave shiny in DESCRIPTION some minor clean-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are used by many functions inside the package so they belong there (R CMD check was not happy, for good reasons).