Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake file #32

Closed
wants to merge 3 commits into from
Closed

CMake file #32

wants to merge 3 commits into from

Conversation

ProGTX
Copy link

@ProGTX ProGTX commented Jan 11, 2018

I wasn't able to run the Makefile on Windows, so I've written this simple CMake file. I managed to compile clinfo with this using Visual Studio 2017. The CMake file is much simpler than the Makefile and also platform independent.

One note, though, I don't know how to handle the man1 folder in CMake.

@Oblomov
Copy link
Owner

Oblomov commented Jan 12, 2018

I appreciate the effort, but as I commented on #20 already, I would rather not add an extra dependency when building can be achieved with a simple make.

@Oblomov Oblomov closed this Jan 12, 2018
Oblomov added a commit that referenced this pull request Jan 27, 2018
Hopefully this will be sufficient to let people know that CMake is
intentionally not used (ref. issue #20 and pull request #32).
@Foadsf
Copy link

Foadsf commented Jun 7, 2020

I would rather not add an extra dependency when building can be achieved with a simple make.

It doesn't! One can't compile on Windows using native compilers and toolchains provided by Microsoft.

Options are:

  • Installing MinGW/MSYS2 which is a dependency, and a messy one!
  • Using CMake, which is the canonical way of building cross-platform software
  • Using NMAKE.EXE as explained here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants