Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bypass definition hash verification with --no-verify flag #1084

Closed
dB2510 opened this issue Sep 6, 2022 · 0 comments · Fixed by #1099
Closed

Bypass definition hash verification with --no-verify flag #1084

dB2510 opened this issue Sep 6, 2022 · 0 comments · Fixed by #1099
Assignees
@dB2510
Labels
refactor Code refactoring

Comments

@dB2510
Copy link
Contributor

dB2510 commented Sep 6, 2022 •
edited
Loading

Problem to be solved

We are having issues with generating definition hash on DV launchpad side. Due to this, currently DV launchpad supports cluster-definition.json without definition_hash field. We need to bypass definition_hash verification for charon dkg command using --no-verify flag.

Proposed solution

Move config hash verification and definition hash verification from UnmarshalJSON method to Verify method of Definition type. Add unit test to verify above usecase. Also move lock hash verification from UnmarshalJSON method to Verify method of Lock type.
@dB2510 dB2510 added the refactor Code refactoring label Sep 6, 2022
@dB2510 dB2510 self-assigned this Sep 6, 2022
@dB2510 dB2510 mentioned this issue Sep 7, 2022
Closed
@dB2510 dB2510 linked a pull request Sep 7, 2022 that will close this issue
dkg: add --no-verify for hash verifications #1090
Closed
@dB2510 dB2510 mentioned this issue Sep 8, 2022
Merged
@dB2510 dB2510 linked a pull request Sep 8, 2022 that will close this issue
dkg: add --no-verify for hash verifications #1099
Merged
obol-bulldozer bot pushed a commit that referenced this issue Sep 8, 2022
@dB2510
dkg: add --no-verify for hash verifications (#1099)
ea4a0b1 
Configure --no-verify for config_hash and definition_hash verifications by adding VerifyHashes method to Definition.

category: refactor
ticket: #1084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
refactor Code refactoring
Projects
None yet
Milestone
No milestone
1 participant
@dB2510