dkg: add --no-verify for hash verifications #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
- Coverage 53.40% 53.03% -0.38%
==========================================
Files 127 127
Lines 14292 14300 +8
==========================================
- Hits 7633 7584 -49
- Misses 5560 5620 +60
+ Partials 1099 1096 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
corverroos
reviewed
Sep 8, 2022
cluster/definition.go
Outdated
| } | ||
|
|
||
| // VerifyHashes returns an error if hashes populated from json object doesn't matches actual hashes. | ||
| func (d Definition) VerifyHashes() error { |
There was a problem hiding this comment.
VerifyDefinitionHashes since we will add VerifyLockHashes and both method appear on the Lock struct
corverroos
approved these changes
Sep 8, 2022
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure --no-verify for config_hash and definition_hash verifications by adding VerifyHashes method to Definition.
category: refactor
ticket: #1084