Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle feeRecipient gracefully #1100

Closed
OisinKyne opened this issue Sep 8, 2022 · 2 comments · Fixed by #1246
Closed

Handle feeRecipient gracefully #1100

OisinKyne opened this issue Sep 8, 2022 · 2 comments · Fixed by #1246
Assignees
@dB2510

Comments

@OisinKyne
Copy link
Contributor

OisinKyne commented Sep 8, 2022 •
edited
Loading

🐞 Bug Report

Description

It's not clear we use the feeRecipient field barely at all bar MEV-boost registration. We should assert that we use it properly from the cluster-lock and nowhere else.

Has this worked before in a previous version?

No

🔬 Minimal Reproduction

🔥 Error

🌍 Your Environment

What version of Charon are you running? (Which release)

v0.10

Anything else relevant (validator index / public key)?

Solution

Log feeRecipient in charon run.
@xenowits xenowits self-assigned this Sep 21, 2022
@OisinKyne
Copy link
Contributor Author

Outstanding Qs:

  • How do we override default validator set fee recipients
  • Can we default feeRecipient to withdrawalAddress?
  • Can we enforce a single feeRecipient

@corverroos
Copy link
Contributor

corverroos commented Oct 3, 2022 •
edited
Loading

Similar to builder registrations, the beacon api has a POST /eth/v1/validator/prepare_beacon_proposer endpoint to provide your desired fee recipient for block proposal. See https://ethereum.github.io/beacon-APIs/#/ValidatorRequiredApi/prepareBeaconProposer.

We should:

  • Call this endpoint with the lock file fee recipient every epoch
  • Proxy this endpoint and update whatever the VCs provide before sending upstream.
  • Ensure the correct fee recipient is received when fetching a block

@corverroos corverroos assigned dB2510 and unassigned corverroos Oct 10, 2022
@dB2510 dB2510 mentioned this issue Oct 10, 2022
Merged
@dB2510 dB2510 linked a pull request Oct 10, 2022 that will close this issue
app: handle fee recipient #1246
Merged
obol-bulldozer bot pushed a commit that referenced this issue Oct 10, 2022
@dB2510
app: handle fee recipient (#1246)
eac1119 
Handles fee recipient address by adding a slot subscriber to scheduler which calls prepare_beacon_proposer endpoint at the start of each epoch.

category: feature
ticket: #1100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

app: handle fee recipient ObolNetwork/charon
4 participants
@OisinKyne @corverroos @dB2510 @xenowits