app: handle fee recipient #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.54% // Head: 53.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
+ Coverage 53.54% 53.59% +0.05%
==========================================
Files 139 139
Lines 16152 16284 +132
==========================================
+ Hits 8648 8728 +80
- Misses 6260 6298 +38
- Partials 1244 1258 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
corverroos
reviewed
Oct 10, 2022
app/app.go
Outdated
| // setFeeRecipient returns a slot subscriber for scheduler which calls prepare_beacon_proposer endpoint at start of each epoch. | ||
| func setFeeRecipient(eth2Cl eth2wrap.Client, pubkeys []eth2p0.BLSPubKey, feeRecipient string) func(ctx context.Context, slot core.Slot) error { | ||
| return func(ctx context.Context, slot core.Slot) error { | ||
| if !slot.FirstInEpoch() { |
There was a problem hiding this comment.
also do this on startup (ie the first time it is called)
corverroos
reviewed
Oct 10, 2022
core/fetcher/fetcher.go
Outdated
| if block.Version == spec.DataVersionBellatrix { | ||
| actual := fmt.Sprintf("%#x", block.Bellatrix.Body.ExecutionPayload.FeeRecipient) | ||
| if actual != f.feeRecipientAddress { | ||
| log.Warn(ctx, "Fee recipient address different than expected", nil, |
There was a problem hiding this comment.
Proposing block with unexpected fee recipient address
corverroos
reviewed
Oct 10, 2022
| @@ -650,6 +655,12 @@ func submitSyncCommitteeMessages(s eth2client.SyncCommitteeMessagesSubmitter) ha | |||
| } | |||
| } | |||
|
|
|||
| func submitProposalPreparations() handlerFunc { | |||
| return func(context.Context, map[string]string, url.Values, []byte) (interface{}, error) { | |||
| return nil, nil | |||
There was a problem hiding this comment.
add a comment why we swallow this
corverroos
approved these changes
Oct 10, 2022
corverroos
approved these changes
Oct 10, 2022
app/app.go
Outdated
| // setFeeRecipient returns a slot subscriber for scheduler which calls prepare_beacon_proposer endpoint at start of each epoch. | ||
| // TODO(dhruv): move this somewhere else once more use-cases like this becomes clear. | ||
| func setFeeRecipient(eth2Cl eth2wrap.Client, pubkeys []eth2p0.BLSPubKey, feeRecipient string) func(ctx context.Context, slot core.Slot) error { | ||
| onStartup := false |
There was a problem hiding this comment.
suggest:
onStartup := true
...
if !onStartup && !slot.FirstInEpoch() {
return nil
}
onStartup = false
dB2510
added
merge when ready
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles fee recipient address by adding a slot subscriber to scheduler which calls prepare_beacon_proposer endpoint at the start of each epoch.
category: feature
ticket: #1100