Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated consensus wire protocol fields #1555

Closed
corverroos opened this issue Dec 14, 2022 · 0 comments
Closed

Remove deprecated consensus wire protocol fields #1555

corverroos opened this issue Dec 14, 2022 · 0 comments

Comments

@corverroos
Copy link
Contributor

Problem to be solved

The value fields for qbft consensus wire messages were refactored to any protos in #1214, this was released in v0.11. The previous values has not been removed yet (for backwards compatibility), but this is causing double the amount network bandwith which is a problem for synthetic blocks. And it is time to compete the upgrade and drop support for old versions.

Note this will remove support for v0.10 and before, so v0.13 will only be compatible with v0.11 and v0.12

Proposed solution

Remove support for deprecated fields.

obol-bulldozer bot pushed a commit that referenced this issue Dec 14, 2022
Removes deprecated consensus wire protocol fields. New fields were introduced in v0.11, so this removes compatibility with v0.10 and older.

category: refactor
ticket: #1555
obol-bulldozer bot pushed a commit that referenced this issue Dec 14, 2022
Reverts "reserved" fields since they are required to calculate correct hash when verifying signatures. Instead just stop using fields. 

category: bug
ticket: #1555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant