Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor core workflow types #163

Closed
corverroos opened this issue Mar 2, 2022 · 0 comments
Closed

Refactor core workflow types #163

corverroos opened this issue Mar 2, 2022 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@corverroos
Copy link
Contributor

corverroos commented Mar 2, 2022

Problem to solve

The core workflow types (DutyArg, DutyArgSet, etc) can be simplified.

Also, I think we should refactor DV identifier from VIdx PubKey. This was the original design, and since we now have explicit DutyArg/FetchArg type, we do not need to pull query args to the top level of the type system. Another reason why DVs should be identified by the pubkey rather than then VIdx, is that when downstream components need to lookup TSS from the manifest, doing so via the VIdx require additional shared state, while PubKey doesn't.

Proposed solution

If we assume the project structure in #155:

  • Refactor VIdx -> PubKey
  • Keep Duty
  • Rename DutyArg -> FetchArg (and FetchArgSet)
  • Rename DutyData -> UnsignedData (and UnsignedDataSet)
  • Rename SignedDutyData -> ParSignedData (and ParSignedDataSet)
  • Introduce -> AggSignedData (and AggSignedDataSet)
  • Rename SigDB -> ParSigDB
  • Rename SigEx -> ParSigEx
  • Rename AggDB -> AggSigDB
@corverroos corverroos added the documentation Improvements or additions to documentation label Mar 2, 2022
@corverroos corverroos self-assigned this Mar 3, 2022
corverroos added a commit that referenced this issue Mar 4, 2022
Refactors core workflow types to be more intuitive, also moves from `VIdx` to `PubKey` as validator identifier.

category: refactor
ticket: #163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant