Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: propose project structure #155

Merged
merged 4 commits into from
Mar 3, 2022
Merged

docs: propose project structure #155

merged 4 commits into from
Mar 3, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Mar 1, 2022 •
edited
Loading

Proposes slightly modified project structure.

  • Moves all "core workflow" business logic under core/.
  • Important libs and services stay in root, like tbls/ and p2p/
  • All test libs move to testutil/.
  • Application infrastructure libs remain under app/

category: docs
ticket: #146

@codecov
Copy link

codecov bot commented Mar 1, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@de7100f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage        ?   54.55%           
=======================================
  Files           ?       30           
  Lines           ?     1976           
  Branches        ?        0           
=======================================
  Hits            ?     1078           
  Misses          ?      792           
  Partials        ?      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de7100f...f1c334c. Read the comment docs.

@corverroos corverroos mentioned this pull request Mar 2, 2022
Closed
dB2510
dB2510 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

docs/structure.md Show resolved Hide resolved
docs/structure.md Outdated Show resolved Hide resolved
@corverroos corverroos merged commit 1469f91 into main Mar 3, 2022
@corverroos corverroos deleted the corver/strcture branch March 3, 2022 08:45
@corverroos corverroos mentioned this pull request Mar 3, 2022
Merged
corverroos added a commit that referenced this pull request Mar 4, 2022
@corverroos
*: refactor project structure (#171)
5f78a1e 
Aligns code with new project structure proposal in #155.

category: refactor
ticket: #146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dB2510 dB2510 dB2510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corverroos @dB2510