Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use withdrawal-addresses from cluster-definition v1.5.0 #1650

Closed
dB2510 opened this issue Jan 18, 2023 · 0 comments
Closed

Use withdrawal-addresses from cluster-definition v1.5.0 #1650

dB2510 opened this issue Jan 18, 2023 · 0 comments
Assignees
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Jan 18, 2023

Problem to be solved

We are adding support for multiple withdrawal addresses as part of our v1.5.0 cluster definition upgrade. For more details refer this issue. We need to support multiple withdrawal addresses in our workflow while creating deposit-data.json.

Proposed solution

Add support of multiple withdrawal addresses while creating deposit-data.json. We create deposit-data.json at two instances: charon create cluster and charon dkg commands.

  • Add flags for taking multiple withdrawal addresses as --withdrawal-addresses which will be an array of strings to charon create cluster and charon create dkg commands.
  • --withdrawal-addresses flag should take either one address only or address for each validator len(withdrawal-addresses) == numValidators to avoid support of any other edge case.
  • Use withdrawal addresses from cluster-definition to create/sign deposit data corresponding to each validator public key in charon create cluster and charon dkg commands.
  • Add unit tests.
  • Test all the relevant commands manually.

Out of Scope

If there is anything to highlight as out of scope for this issue, please outline it here.

@thomasheremans thomasheremans added the protocol Protocol Team tickets label Jan 23, 2023
obol-bulldozer bot pushed a commit that referenced this issue Jan 27, 2023
Uses multiple withdrawal addresses while creating deposit data.

category: feature
ticket: #1650
@dB2510 dB2510 closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

2 participants