Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: use multiple withdrawal addresses #1687

Merged
merged 5 commits into from
Jan 27, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jan 25, 2023

Uses multiple withdrawal addresses while creating deposit data.

category: feature
ticket: #1650

@dB2510 dB2510 changed the title Dhruv/use multi withdrawal addrs cmd: use multiple withdrawal addresses Jan 25, 2023
eth2util/deposit/deposit.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 54.70% // Head: 54.68% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (228d4d8) compared to base (29977ee).
Patch coverage: 52.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
- Coverage   54.70%   54.68%   -0.02%     
==========================================
  Files         159      159              
  Lines       20718    20736      +18     
==========================================
+ Hits        11334    11340       +6     
- Misses       7861     7870       +9     
- Partials     1523     1526       +3     
Impacted Files Coverage Δ
dkg/dkg.go 53.66% <47.22%> (+0.10%) ⬆️
cmd/createcluster.go 51.93% <51.85%> (-0.27%) ⬇️
eth2util/deposit/deposit.go 54.26% <61.53%> (-1.65%) ⬇️
dkg/disk.go 53.90% <62.50%> (-0.47%) ⬇️
app/vmock.go 71.50% <0.00%> (-1.04%) ⬇️
core/qbft/qbft.go 83.82% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/createcluster.go Outdated Show resolved Hide resolved
dkg/dkg.go Show resolved Hide resolved
eth2util/deposit/deposit.go Show resolved Hide resolved
@dB2510 dB2510 force-pushed the dhruv/use-multi-withdrawal-addrs branch from 1682e44 to dda18c2 Compare January 27, 2023 12:45
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 27, 2023
@obol-bulldozer obol-bulldozer bot merged commit e090f18 into main Jan 27, 2023
@obol-bulldozer obol-bulldozer bot deleted the dhruv/use-multi-withdrawal-addrs branch January 27, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants