You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When receiving message frost round messages from peers in newFrostP2P, we do not verify the message contents. See original sigma-prime thread
🛠️ Proposed solution
Check FrostMsgKey:
Message Keys:
- FrostRound1Msg
- Each element of Casts []*FrostRound1Cast check Key *FrostMsgKey
- Each element of P2Ps ShamirShare check Key *FrostMsgKey
- FrostRound2Msg
- Each elemeent of Casts []*FrostRound2Cast check Key *FrostMsgKey
For the FrostMsgKey that are listed above validate
- 0 <= ValIdx < numValidators
- 1 <= SourceId <= numNodes
- 1 <= TargetId <= numNodes
- SourceId matches the peer ID (can check frostP2P.peers[sourceId] == s.Conn().RemotePeer()
- TargetId matches our peer ID (this is done already in that we ignore other messages)
Describe the solution to be implemented
🧪 Tests
Tested by new automated unit/integration/smoke tests
Manually tested on core team/canary/test clusters
Manually tested on local compose simnet
The text was updated successfully, but these errors were encountered:
Adds check to ensure validator indexes (`ValIdx`) in frost DKG messages are in the range `[0, num_validators)`.
Also refactors out broadcast and p2p callbacks and adds tests for them.
category: feature
ticket: #1888
🎯 Problem to be solved
When receiving message frost round messages from peers in
newFrostP2P
, we do not verify the message contents. See original sigma-prime thread🛠️ Proposed solution
Check
FrostMsgKey
:Describe the solution to be implemented
🧪 Tests
The text was updated successfully, but these errors were encountered: