-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dkg: verify valIdx in frost dkg messages #2107
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2107 +/- ##
==========================================
+ Coverage 53.51% 53.76% +0.24%
==========================================
Files 171 172 +1
Lines 22252 22299 +47
==========================================
+ Hits 11909 11989 +80
+ Misses 8893 8871 -22
+ Partials 1450 1439 -11
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test?
Adds check to ensure validator indexes (
ValIdx
) in frost DKG messages are in the range[0, num_validators)
.Also refactors out broadcast and p2p callbacks and adds tests for them.
category: feature
ticket: #1888