Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dkg: verify valIdx in frost dkg messages #2107

Merged
merged 8 commits into from
Apr 20, 2023

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Apr 17, 2023

Adds check to ensure validator indexes (ValIdx) in frost DKG messages are in the range [0, num_validators).

Also refactors out broadcast and p2p callbacks and adds tests for them.

category: feature
ticket: #1888

@xenowits xenowits self-assigned this Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 87.62% and project coverage change: +0.24 🎉

Comparison is base (617306e) 53.51% compared to head (be3b64a) 53.76%.

❗ Current head be3b64a differs from pull request most recent head 81574b8. Consider uploading reports for the commit 81574b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
+ Coverage   53.51%   53.76%   +0.24%     
==========================================
  Files         171      172       +1     
  Lines       22252    22299      +47     
==========================================
+ Hits        11909    11989      +80     
+ Misses       8893     8871      -22     
+ Partials     1450     1439      -11     
Impacted Files Coverage Δ
dkg/frostp2p.go 75.07% <87.50%> (+11.61%) ⬆️
dkg/dkg.go 59.38% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

dkg/frostp2p.go Outdated Show resolved Hide resolved
Copy link
Contributor

@corverroos corverroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test?

dkg/frostp2p.go Show resolved Hide resolved
dkg/frostp2p.go Outdated Show resolved Hide resolved
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 20, 2023
@obol-bulldozer obol-bulldozer bot merged commit 764a161 into main Apr 20, 2023
@obol-bulldozer obol-bulldozer bot deleted the xenowits/remaining-checks branch April 20, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants