Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DKG doesn't support peerinfo protocol for relays #1978

Closed
corverroos opened this issue Mar 30, 2023 · 0 comments
Closed

DKG doesn't support peerinfo protocol for relays #1978

corverroos opened this issue Mar 30, 2023 · 0 comments
Assignees
@corverroos
Labels
protocol Protocol Team tickets

Comments

@corverroos
Copy link
Contributor

corverroos commented Mar 30, 2023 •
edited
Loading

🐞 Bug Report

Description

We removed the relay's p2p.SupportedProtocol check, so it errors with protocols not supported: [/charon/peerinfo/1.0.0 when DKG peers connect to it since they DKG command doesn't instantiate a peerinfo handler.

This isn't a critical issue since it only results in error logs in relay as well as some missing relay metrics.

Solution

DKG should instantiate a peerinfo handler.
@github-actions github-actions bot added the protocol Protocol Team tickets label Mar 30, 2023
@corverroos corverroos mentioned this issue Mar 30, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Mar 30, 2023
@corverroos
dkg: enable peerinfo server (#1982)
b2ad529 
Enables peerinfo server handler in DKG command so nodes identify themselves to relays. This mitigates the "protocol not supported errors" in the relay when DKG happens.

category: bug
ticket: #1978
@dB2510 dB2510 changed the title DGK doesn't support peerinfo protocol for relays DKG doesn't support peerinfo protocol for relays Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corverroos corverroos

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corverroos