Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return dependent root from validatorapi #2736

Closed
3 tasks done
dB2510 opened this issue Dec 1, 2023 · 1 comment
Closed
3 tasks done

Return dependent root from validatorapi #2736

dB2510 opened this issue Dec 1, 2023 · 1 comment
Assignees
@pinebit
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Dec 1, 2023 •
edited by pinebit

🎯 Problem to be solved

We need to return a proper dependent_root field as response to the duties endpoints. This is causing lodestar to flood WARN logs every slot:

Potential current epoch attester duties reorg slot=408896, dutyEpoch=12778, priorDependentRoot=0xea63000000000000000000000000000000000000000000000000000000000000

🛠️ Proposed solution

As part of recent go-eth2-client upgrade, it has started returning the dependent_root field as part of metadata which was absent in earlier versions. We need to add support of this field while returning response through validatorapi for VCs.
https://github.com/attestantio/go-eth2-client/blob/677e48992f5edabadc5acbaf11b8db654ac47c07/http/attesterduties.go#L84

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Dec 1, 2023
@pinebit pinebit self-assigned this Dec 5, 2023
@pinebit pinebit mentioned this issue Dec 6, 2023
Merged
@boulder225
Copy link
Collaborator

Please add your planning poker estimate with Zenhub @pinebit

obol-bulldozer bot pushed a commit that referenced this issue Dec 11, 2023
@pinebit
validatorapi: handling duties response metadata (#2739)
72c80c7 
As part of recent go-eth2-client upgrade, `ProposerDuties` and `AttesterDuties` calls started to return Metadata fields: 
```
  "dependent_root": "0xc01a8003a974cea31fd9e91c7d2cec8120ea3cc71edcbb836b6fbede6c289a69",
  "execution_optimistic": false,
```

This change updates the corresponding handlers of validator API to properly parse and propagate these new fields. 

category: feature
ticket: #2736
@pinebit pinebit mentioned this issue Dec 12, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Dec 12, 2023
@pinebit
validatorapi: fixed dependent_root metadata type (#2748)
078a37c 
go-eth2-client handles `dependent_root` metadata as a special case and produces a `Root` object rather than hex string.
  
https://github.com/attestantio/go-eth2-client/blob/a05485e0e75749f2b6912db2972a35ec2ec37c3b/http/json.go#L32C25-L32C25

category: bug
ticket: #2736
@pinebit pinebit closed this as completed Dec 12, 2023
xenowits pushed a commit that referenced this issue Dec 12, 2023
@pinebit @xenowits
validatorapi: handling duties response metadata (#2739)
7af36ea 
As part of recent go-eth2-client upgrade, `ProposerDuties` and `AttesterDuties` calls started to return Metadata fields: 
```
  "dependent_root": "0xc01a8003a974cea31fd9e91c7d2cec8120ea3cc71edcbb836b6fbede6c289a69",
  "execution_optimistic": false,
```

This change updates the corresponding handlers of validator API to properly parse and propagate these new fields. 

category: feature
ticket: #2736
xenowits pushed a commit that referenced this issue Dec 12, 2023
@pinebit @xenowits
validatorapi: fixed dependent_root metadata type (#2748)
55fb691 
go-eth2-client handles `dependent_root` metadata as a special case and produces a `Root` object rather than hex string.
  
https://github.com/attestantio/go-eth2-client/blob/a05485e0e75749f2b6912db2972a35ec2ec37c3b/http/json.go#L32C25-L32C25

category: bug
ticket: #2736
gsora pushed a commit that referenced this issue Dec 21, 2023
@pinebit @gsora
validatorapi: handling duties response metadata (#2739)
3e3cd69 
As part of recent go-eth2-client upgrade, `ProposerDuties` and `AttesterDuties` calls started to return Metadata fields: 
```
  "dependent_root": "0xc01a8003a974cea31fd9e91c7d2cec8120ea3cc71edcbb836b6fbede6c289a69",
  "execution_optimistic": false,
```

This change updates the corresponding handlers of validator API to properly parse and propagate these new fields. 

category: feature
ticket: #2736
gsora pushed a commit that referenced this issue Dec 21, 2023
@pinebit @gsora
validatorapi: fixed dependent_root metadata type (#2748)
efa68ca 
go-eth2-client handles `dependent_root` metadata as a special case and produces a `Root` object rather than hex string.
  
https://github.com/attestantio/go-eth2-client/blob/a05485e0e75749f2b6912db2972a35ec2ec37c3b/http/json.go#L32C25-L32C25

category: bug
ticket: #2736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinebit pinebit

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pinebit @dB2510 @boulder225