validatorapi: fixed dependent_root metadata type #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
dB2510
approved these changes
Dec 12, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
==========================================
- Coverage 53.36% 53.31% -0.05%
==========================================
Files 199 199
Lines 27533 27527 -6
==========================================
- Hits 14692 14676 -16
- Misses 11019 11031 +12
+ Partials 1822 1820 -2 ☔ View full report in Codecov by Sentry. |
pinebit
added
the
merge when ready
xenowits
pushed a commit
that referenced
this pull request
Dec 12, 2023
go-eth2-client handles `dependent_root` metadata as a special case and produces a `Root` object rather than hex string. https://github.com/attestantio/go-eth2-client/blob/a05485e0e75749f2b6912db2972a35ec2ec37c3b/http/json.go#L32C25-L32C25 category: bug ticket: #2736
gsora
pushed a commit
that referenced
this pull request
Dec 21, 2023
go-eth2-client handles `dependent_root` metadata as a special case and produces a `Root` object rather than hex string. https://github.com/attestantio/go-eth2-client/blob/a05485e0e75749f2b6912db2972a35ec2ec37c3b/http/json.go#L32C25-L32C25 category: bug ticket: #2736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-eth2-client handles
dependent_rootmetadata as a special case and produces aRootobject rather than hex string.https://github.com/attestantio/go-eth2-client/blob/a05485e0e75749f2b6912db2972a35ec2ec37c3b/http/json.go#L32C25-L32C25
category: bug
ticket: #2736