Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy and Integrate bulldozer bot #325

Closed
dB2510 opened this issue Mar 31, 2022 · 1 comment
Closed

Deploy and Integrate bulldozer bot #325

dB2510 opened this issue Mar 31, 2022 · 1 comment
Assignees
@dB2510
Labels
enhancement New feature or request

Comments

@dB2510
Copy link
Contributor

dB2510 commented Mar 31, 2022

Problem to be solved

Need a Bulldozer bot auto-merging PRs when they certain conditions.

Proposed solution

Ref: https://github.com/palantir/bulldozer
@dB2510 dB2510 added the enhancement New feature or request label Mar 31, 2022
@dB2510 dB2510 self-assigned this Mar 31, 2022
@corverroos corverroos mentioned this issue Apr 5, 2022
Merged
github-actions bot pushed a commit that referenced this issue Apr 5, 2022
@corverroos
testutil: implement merge-pr action (#356)
2077b8f 
Implements a simple PR merge action that:
 - Is triggered when a label is added to the PR
 - Checks if all actions/checks have passed
 - The `merge when ready` is applied.
 - Then merges the PR using our guidelines.

category: feature 
ticket: #325
@corverroos corverroos mentioned this issue Apr 5, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 5, 2022
@corverroos
testutil/mergepr: change label to merge now (#357)
5e40fca 
Github actions cannot be easily be triggered when all checks completed. So "merge when ready" is misleading. Change the label to trigger a merge attempt to "merge now". Since adding a label triggers the action and all checks should have passed at that point already.

category: refactor
ticket: #325
@dB2510 dB2510 mentioned this issue Apr 6, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 6, 2022
@dB2510
update .bulldozer.yml (#361)
85337ba 
Removed target branch trigger, and updated label and comment trigger. This issue was letting bulldozer bot to merge any PR if the target is main. Ref: palantir/bulldozer#304

category: bug
ticket: #325
@dB2510
Copy link
Contributor Author

dB2510 commented Apr 6, 2022

Closed by #361 and https://github.com/ObolNetwork/obol-infrastructure/pull/18

@dB2510 dB2510 closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dB2510