Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/mergepr: change label to merge now #357

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Apr 5, 2022

Github actions cannot be easily be triggered when all checks completed. So "merge when ready" is misleading. Change the label to trigger a merge attempt to "merge now". Since adding a label triggers the action and all checks should have passed at that point already.

category: refactor
ticket: #325

@corverroos corverroos added merge when ready Indicates bulldozer bot may merge when all checks pass and removed merge when ready Indicates bulldozer bot may merge when all checks pass labels Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #357 (4bd2225) into main (fb5591c) will decrease coverage by 1.48%.
The diff coverage is 0.00%.

❗ Current head 4bd2225 differs from pull request most recent head a8e2efd. Consider uploading reports for the commit a8e2efd to get more accurate results

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   55.68%   54.19%   -1.49%     
==========================================
  Files          62       63       +1     
  Lines        5332     5484     +152     
==========================================
+ Hits         2969     2972       +3     
- Misses       1962     2113     +151     
+ Partials      401      399       -2     
Impacted Files Coverage Δ
testutil/mergepr/mergepr.go 0.00% <0.00%> (ø)
app/app.go 64.51% <0.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2077b8f...a8e2efd. Read the comment docs.

@corverroos corverroos removed the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 5, 2022
Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge now!

@corverroos corverroos added the bug Something isn't working label Apr 5, 2022
@corverroos corverroos added merge when ready Indicates bulldozer bot may merge when all checks pass help wanted Extra attention is needed and removed bug Something isn't working merge when ready Indicates bulldozer bot may merge when all checks pass help wanted Extra attention is needed labels Apr 5, 2022
@obol-bulldozer obol-bulldozer bot merged commit 5e40fca into main Apr 5, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/mergenows branch April 5, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants